Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak #362

Closed
Tracked by #880
KatieWoe opened this issue Dec 23, 2022 · 5 comments
Closed
Tracked by #880

Memory Leak #362

KatieWoe opened this issue Dec 23, 2022 · 5 comments

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#870. Seen on Win 11 Chrome
These are the results from the memory test. It seems to indicate a memory leak somewhere.
skatemem

@jessegreenberg
Copy link
Contributor

Thanks @KatieWoe. I wonder if this is caused by recent string -> StringProperty conversions in #350.

@samreid
Copy link
Member

samreid commented Jan 3, 2023

@AgustinVallejo and @jbphet will coordinate on this on Jan 4, thanks!

@samreid
Copy link
Member

samreid commented Jan 4, 2023

@jonathanolson also corrected a memory leak in font awesome nodes in this commit: phetsims/sherpa@68ffa3d

I tested fuzzing for 20 minutes and it seems stable. I think this issue is ready to close.
image

Though I am not sure the full timeline or steps to recreate a table like #362 (comment). @AgustinVallejo do you think this issue can be closed? Do you want a double check by @KatieWoe ?

@samreid
Copy link
Member

samreid commented Jan 4, 2023

I got another reading at 30 minutes, so I'm feeling more confident about this:

image

@KatieWoe
Copy link
Contributor Author

Memory test looks good in rc.2
newmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants