New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with removeEnergyChunk #411

Open

3 tasks

samreid opened this issue Jun 29, 2021 · 1 comment

Member

samreid commented Jun 29, 2021 •

edited

Loading

Identified in phetsims/chipper#1033, there are some problems with removeEnergyChunk:

The return value is never used
Returning true from the arrow function doesn't stop iteration--could be removed from multiple groups
Lint offense (I'll commit a disable-line which should be cleaned up)

I was going to fix it, but not sure if the sim is relying on the buggy implementation of removal from multiple groups.

samreid assigned chrisklus

samreid added a commit that referenced this issue


          Disable lint rule for consistent-return, see #411

682badf

Contributor

chrisklus commented Apr 28, 2023

Thanks @samreid - leaving this issue unassigned until work on this sim is scheduled.

chrisklus removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment