-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User reported issue: heat capacity values #404
Comments
This method makes the assumption that the blocks have the same mass, which is incorrect. Brick and iron have the same volume, but the iron block is several times heavier than the brick. If they adjust for the differences in mass (by using the densities), this method will work. I tested it using the values currently in the model, and everything checks out. However, I think that the brick density used in the model is too high (currently 3300 kg/m³). The comment in the code says it comes from the design doc, but those values are not actually sourced. I'm willing to bet they are the values we used in Java. According to Wikipedia:
I've found other sources which put the density of brick in the 1400-2400 kg/m³ range, so 2000 kg/m³ sounds like a more reasonable value.
It seems like we should change the brick density in the model, but I am a bit hesitant since the code currently says the value was tweaked to "keep chunk numbers reasonable". @kathy-phet what are your recommended next steps? |
@arouinfar looked into this a little bit and ran into an assertion for expected preset values when we changed the brick density to a more accurate number mentioned in #404 (comment). I'll have to investigate more or talk to @jbphet about how these preset values work - I know they were added to speed up start time / reset time. Leaving assigned to @kathy-phet for recommendations on if any changes here should be implemented for the next release. |
Another user wrote to phethelp about the heat capacity of the bricks. The values they cite match the specific heat in the model, but because we have an unrealistic brick density, the user does not observe the behavior they would expect.
|
Self-assigned to get this on my radar. |
Here is what is in the code as of this writing: BRICK_DENSITY = 3300; // in kg/m^3, source = design document plus some tweaking to keep chunk numbers reasonable
BRICK_SPECIFIC_HEAT = 840; // in J/kg-K, source = design document
IRON_DENSITY: 7800, // In kg/m^3, source = design doc
IRON_SPECIFIC_HEAT: 450, // In J/kg-K, source = design doc Here is part of a table I just found online for densities and specific heats of building materials (URL = https://www.greenspec.co.uk/building-design/thermal-mass/): So, assuming steel is close to iron, we seem to be using pretty realistic values for iron and a bit of an unrealistic density for the brick (though the specific heat is reasonably close). The comment on the brick density says, "design document plus some tweaking to keep chunk numbers reasonable", so I think we probably did some "hollywooding" here to get the behavior we wanted. This could, of course, be changed to be more realistic, but there would be consequences. We could also consider a different material that is closer to what we're after. @arouinfar - I'm hitting this back into your court. I'd be happy to meet with you during design meeting time to discuss options and tweak the values and see how it affects the behavior. |
Republishing this sim will eventually be a priority, let's discuss then. For now, I'm going to unassing myself. |
Related user email into phethelp:
|
Assigning to @arouinfar to respond to the query above. |
Forwarded from Carl:
The text was updated successfully, but these errors were encountered: