-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document why removal must be guarded, or remove the guard #403
Comments
Another problem of this type appeared on CT.
|
samreid
added a commit
that referenced
this issue
Dec 7, 2020
samreid
added a commit
that referenced
this issue
Dec 7, 2020
samreid
added a commit
that referenced
this issue
Dec 8, 2020
6 tasks
Leaving this issue unassigned until work on this sim is scheduled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In phetsims/axon#332 we removed the guard from createObservableArray removal methods. I added a sim-specific guard in the following commit, but I'm not sure if it should be documented or eliminated. Assigning to responsible dev to take a look:
5cae5ef
60f5612
The text was updated successfully, but these errors were encountered: