Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document why removal must be guarded, or remove the guard #403

Open
Tracked by #408
samreid opened this issue Dec 6, 2020 · 2 comments
Open
Tracked by #408

Document why removal must be guarded, or remove the guard #403

samreid opened this issue Dec 6, 2020 · 2 comments

Comments

@samreid
Copy link
Member

samreid commented Dec 6, 2020

In phetsims/axon#332 we removed the guard from createObservableArray removal methods. I added a sim-specific guard in the following commit, but I'm not sure if it should be documented or eliminated. Assigning to responsible dev to take a look:

5cae5ef
60f5612

@samreid
Copy link
Member Author

samreid commented Dec 7, 2020

Another problem of this type appeared on CT.

energy-forms-and-changes : fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607341314522/energy-forms-and-changes/energy-forms-and-changes_en.html?continuousTest=%7B%22test%22%3A%5B%22energy-forms-and-changes%22%2C%22fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1607341314522%22%2C%22timestamp%22%3A1607342196340%7D&brand=phet&ea&fuzz&memoryLimit=1000
Query: brand=phet&ea&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed: item not found in Array
Error: Assertion failed: item not found in Array
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607341314522/assert/js/assert.js:25:13)
at arrayRemove (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607341314522/phet-core/js/arrayRemove.js:19:13)
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607341314522/axon/js/createObservableArray.js:349:34
at Proxy.forEach (<anonymous>)
at Proxy.removeAll (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607341314522/axon/js/createObservableArray.js:349:14)
at Biker.extractOutgoingEnergyChunks (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607341314522/energy-forms-and-changes/js/systems/model/EnergySource.js:52:26)
at SystemsModel.stepModel (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607341314522/energy-forms-and-changes/js/systems/model/SystemsModel.js:261:42)
at SystemsModel.step (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607341314522/energy-forms-and-changes/js/systems/model/SystemsModel.js:245:12)
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607341314522/joist/js/Sim.js:282:22
at Action.execute (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607341314522/axon/js/Action.js:225:18)
id: Bayes Chrome
Snapshot from 12/7/2020, 4:41:54 AM

@chrisklus
Copy link
Contributor

Leaving this issue unassigned until work on this sim is scheduled

@chrisklus chrisklus removed their assignment Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants