-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document relationship between images and assets #261
Comments
Understood - I didn't know this was a big deal. During the development of the sim, whenever we had to change one of the original images, @arouinfar just made a new one since we didn't have the original .ai files and since they typically had an outdated look.
I didn't know we had a convention for linking images to assets in the license file. That sounds very nice and helpful. I'll do this as part of the work for this issue.
I'm unfamiliar with Unfuddle but will have someone help me look for them there. |
Per discussion with @ariel-phet before 08/22/19 dev meeting, we won't have time for cleanup in this issue and #250 before starting PhET-iO instrumentation. Updating to low priority. |
Leaving this issue unassigned until work on this sim is scheduled. |
Related to code review #247
In #243 (self code review), @chrisklus noted:
This is not an acceptable answer. This sim has a whopping 104 images files. Not only is there no documentation in license.json about which asset files correspond to each image, there is no documentation about which images do not have a corresponding asset file.
And for images that don't have an assert file... Is it possible that these asset files live in Unfuddle but haven't been moved over to GitHub? I see 13 .ai files in Unfuddle that do not live in GitHub.
The text was updated successfully, but these errors were encountered: