Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2 timeline #242

Open
chrisklus opened this issue Jul 22, 2019 · 2 comments
Open

1.2 timeline #242

chrisklus opened this issue Jul 22, 2019 · 2 comments

Comments

@chrisklus
Copy link
Contributor

chrisklus commented Jul 22, 2019

From discussion in design meeting from 7/18/19:

EFAC is going to be instrumented with PhET-iO soon, so before that, we should finish up the work for phet-brand 1.1, which was intended to be released sometime before the start of the 2019-20 school year.

A formal code review has not been done yet, so @pixelzoom is going to do that as early as Monday, 7/29.

During the week of 7/29-8/2, I'm going to spend my sim time responding to issues from the code review and a few other smaller issues, while @jbphet uses his sim time to finish #238, which is the last big issue to fix for 1.1 release.

Hopefully, by sometime during the week of 8/5-8/9, we'll have a dev version published that will serve as a baseline for pre-instrumentation. This may open an opportunity to publish phet-brand 1.1 as well.

EDIT: Per 08/22/19 pre-dev meeting, we are going to abandon publishing 1.1 and instead publish 1.2 with all of the changes from the code review.

Then, I'll do a basic tandem-passing instrumentation as preparation for PhET-iO design meeting, #216.

@pixelzoom
Copy link
Contributor

When you're ready for the final code review, create an issue and assign it to me.

Has someone completed a “self code review” yet? The developer goes through the code-review checklist before passing it to the final reviewer. I typically create an issue for this, like phetsims/gas-properties#122.

@chrisklus
Copy link
Contributor Author

Has someone completed a “self code review” yet? The developer goes through the code-review checklist before passing it to the final reviewer. I typically create an issue for this, like phetsims/gas-properties#122.

@jbphet and I were self reviewing while finishing up 1.0, but I don't remember if we looked over all of the code. I'll do a self-code review before passing off the final review to you.

@chrisklus chrisklus changed the title 1.1 timeline 1.2 timeline Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants