Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FastMatrix3 and improve pooling for Matrix3 #18

Open
samreid opened this issue Apr 29, 2014 · 2 comments
Open

Remove FastMatrix3 and improve pooling for Matrix3 #18

samreid opened this issue Apr 29, 2014 · 2 comments
Labels
dev:enhancement

Comments

@samreid
Copy link
Member

samreid commented Apr 29, 2014

FastMatrix3 is making it difficult to do pooling for Matrix3. We should remove FastMatrix3, and make pooling more pervasive for Matrix3.
@samreid
Copy link
Member Author

samreid commented Apr 29, 2014

I sent this email:

Hi There,

Jon & I have been working on #18 and I wanted to alert you about imminent upcoming changes. We have changed the Matrix3 API, in part to improve support for pooling to reduce garbage collections. We ran into a problem that several sims were trying to position nodes relative to their bounds before their bounds were defined.

I'll push the changes shortly (to about 10 repos) but please be aware of the changes, and let us know if you see any problems.

Thanks,
Sam

samreid added a commit to phetsims/gravity-and-orbits that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see phetsims/dot#18
ab13bbe
samreid added a commit to phetsims/wave-on-a-string that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see phetsims/dot#18
764af3b
samreid added a commit to phetsims/mobius that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see phetsims/dot#18
9d73c19
samreid added a commit to phetsims/kite that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see phetsims/dot#18
11bccf0
samreid added a commit to phetsims/build-a-molecule that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see phetsims/dot#18
e564759
samreid added a commit to phetsims/energy-skate-park-basics that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see phetsims/dot#18
13029a1
samreid added a commit to phetsims/gravity-force-lab that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see phetsims/dot#18
d3f924d
samreid added a commit to phetsims/resistance-in-a-wire that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see phetsims/dot#18
a8f95a1
samreid added a commit to phetsims/scenery that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see phetsims/dot#18
67cefd6
samreid added a commit that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see #18
1efbb57
samreid added a commit to phetsims/sun that referenced this issue Apr 29, 2014
@samreid
Removed FastMatrix3 and improve pooling for Matrix3, see phetsims/dot#18
793aaa4
@samreid
Copy link
Member Author

samreid commented Apr 29, 2014

Commits pushed (see above). Please test and let me or @jonathanolson know if you see any problems. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samreid