Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert repo to TypeScript #125

Open
zepumph opened this issue Mar 4, 2024 · 6 comments
Open

Convert repo to TypeScript #125

zepumph opened this issue Mar 4, 2024 · 6 comments

Comments

@zepumph
Copy link
Member

zepumph commented Mar 4, 2024

I'm surprised to still see so much in JavaScript over here in dot. I ran into this with Bounds3, and will convert it as I butt up against it over in phetsims/density-buoyancy-common#98
@zepumph zepumph self-assigned this Mar 4, 2024
@zepumph
Copy link
Member Author

zepumph commented Mar 4, 2024

image

zepumph added a commit that referenced this issue Mar 4, 2024
@zepumph
rename to typescript, #125
082aa75 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit that referenced this issue Mar 4, 2024
@zepumph
convert to typescript, #125
8a8ed84 
Signed-off-by: Michael Kauzmann <[email protected]>
@zepumph
Copy link
Member Author

zepumph commented Mar 4, 2024

It looks like there was a bug in Bounds3.transform. The jsdoc said that it wanted a Matrix4, but the implementation seems dependent on Matrix3. I added TODOs pointing to this issue. @jonathanolson can you help out with this? I don't see Matrix4.isIdentity().

dot/js/Bounds3.ts

Line 872 in 8a8ed84

* // TODO: should be Matrix4 type, https://github.com/phetsims/dot/issues/125

@zepumph zepumph assigned jonathanolson and unassigned zepumph Mar 4, 2024
@jonathanolson
Copy link
Contributor

It should eventually support Matrix3 (just a rotation) or Matrix4 (rotation + translation).

@samreid
Copy link
Member

samreid commented Mar 7, 2024

I'll work on converting Complex.js to TypeScript.

@samreid samreid self-assigned this Mar 7, 2024
samreid added a commit that referenced this issue Mar 7, 2024
@samreid
Convert to TypeScript (rename only), see #125
dc86e18
samreid added a commit that referenced this issue Mar 7, 2024
@samreid
Convert to TypeScript, see #125
84694b2
@samreid
Copy link
Member

samreid commented Mar 7, 2024

I'll work on Random.js next.

samreid added a commit to phetsims/natural-selection that referenced this issue Mar 7, 2024
@samreid
Convert to TypeScript, see phetsims/dot#125
99d11c7
samreid added a commit to phetsims/axon that referenced this issue Mar 7, 2024
@samreid
Convert to TypeScript, see phetsims/dot#125
49e09c0
samreid added a commit that referenced this issue Mar 7, 2024
@samreid
Convert to TypeScript (rename file only), see #125
e598e8d
samreid added a commit that referenced this issue Mar 7, 2024
@samreid
Convert to TypeScript, see #125
158627b
@samreid samreid removed their assignment Mar 11, 2024
zepumph pushed a commit to phetsims/axon that referenced this issue Mar 19, 2024
@samreid @zepumph
Convert to TypeScript, see phetsims/dot#125
c93c654
jonathanolson added a commit that referenced this issue Jul 30, 2024
@jonathanolson
Fixing Bounds3 correct reference to Matrix4, see #125
f9c40fd
@jonathanolson
Copy link
Contributor

Resolved the Bounds3 bug, now using Matrix4. Unassigning. Matrix4 should be upgraded to match Matrix3 when more work is done on it.

@jonathanolson jonathanolson removed their assignment Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanolson @samreid @zepumph