Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG console error #338

Open
Nancy-Salpepi opened this issue Dec 22, 2023 · 9 comments
Open

SVG console error #338

Nancy-Salpepi opened this issue Dec 22, 2023 · 9 comments
Assignees
Labels

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.1.2

Browser
Safari 17.1.2

Problem description
When testing https://phet-dev.colorado.edu/html/calculus-grapher/1.0.6-rc.1/phet/calculus-grapher_all_phet.html for phetsims/qa#1017, some items in the nav bar disappeared (title, PhET menu, preferences menu) and the screen icons were flipped and upside down.
I haven't been able to reproduce this yet, but there is an SVG error in the console.

Visuals
Screenshot 2023-12-22 at 10 51 42 AM
Screenshot 2023-12-22 at 10 51 57 AM

@pixelzoom
Copy link
Contributor

Yikes.

There have been no changes to this sim, and the problem is in joist. This must be related to SVG work that @jonathanolson has been doing. So unassigning myself.

@jonathanolson
Copy link
Contributor

@amanda-phet and @marlitas, is it possible there's a bad SVG file getting generated here?

@jonathanolson
Copy link
Contributor

Hmm, I'm unable to reproduce, Apple M1 Pro chip, macOS 14.2, Safari 17.2.

@amanda-phet
Copy link
Contributor

amanda-phet commented Dec 22, 2023

I am not sure what svgs are in the navbar. Are the preferences and sound icons svgs?

I couldn't reproduce with my MacBook pro (safari 16.6)

@amanda-phet amanda-phet removed their assignment Dec 22, 2023
@zepumph
Copy link
Member

zepumph commented Dec 22, 2023

I'm on Windows and was not able to reproduce. I would most likely not raise the priority on this until we are able to reproduce it.

@zepumph zepumph removed their assignment Dec 22, 2023
@Nancy-Salpepi
Copy link
Author

I tried for a while earlier today and couldn't reproduce it.

@pixelzoom
Copy link
Contributor

@zepumph said:

... I would most likely not raise the priority on this until we are able to reproduce it.

But it's being reported in an RC, so will presumably be published like this if we don't raise the priority. That said, I have not been able to reproduce this either in Safari 17.1.2. I am running macOS 14.2.1, not 14.1.2.

@zepumph
Copy link
Member

zepumph commented Dec 22, 2023

Yes, it is a challenging concept for PhET at large that there are likely hundreds of bugs in our published sims. We care a lot about the quality of our product! Mostly they are really hard to find and not that destructive to the UX, otherwise we probably would have been able to find and solve it earlier. We are a small team, and need to always determine how best we should spend our time. If 5 people (including the original reporter of the bug) have not been able to figure out how to reproduce the bug, perhaps spending a combined total of an hour on this issue, then likely we should focus on higher priority work.

@marlitas
Copy link
Contributor

marlitas commented Dec 22, 2023

is it possible there's a bad SVG file getting generated here?

We haven't generated any SVGs for common code... Everything has been isolated to sim specific repos. Nothing that I would imagine Calculus Grapher is dependent on.

To double check I went through svg files in the project and confirmed all svgs added by us are isolated to sim repos or common code repos such as area-model-common, and number-line-common. I confirmed that none of these are part of calculus-grapher's dependencies.

@marlitas marlitas removed their assignment Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants