-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to set pdomOrder in CalculusGrapherScreenView #123
Comments
I see that
... and in the subclasses:
|
I'll do this while working on #106. |
This was addressed in the above commit. @veillette ready for review. Note that responsibility for conditionally creating |
Let's discussed today if you should set a flag to support alternative input in |
Yes, let's discuss. But I don't think that we should enable alternative input support yet, because of #125. |
On 12/6, we discussed the PDOM and how we can test the PDOM in phetBrand . In #125, we will addressed the general question of how to support alternative input for the drag handler. The work done here sets the stage to make it easier to set the PDOM in CalculusGrapherScreenView, without actually implementing a PDOM order. We can close this issue. |
So that this sim can easily support alternative input in the future....
In CalculusGrapherScreenView.ts, replace this:
... with:
The reason for this is covered in detail in "Approach 2" of https://github.com/phetsims/phet-info/blob/master/doc/alternative-input-quickstart-guide.md#traversal-order. But in a nutshell, focus traversal (aka "tab order") must to be set via the
pdomOrder
property of a Node, and it cannot be set directly on the ScreenView. So (eventually, you don't need to do this now) thepdomOrder
will be specified in CalculusGrapherScreenView.ts like this:Let me know if you have any questions.
The text was updated successfully, but these errors were encountered: