Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binder TODOs #28

Open
chrisklus opened this issue Dec 30, 2019 · 0 comments
Open

binder TODOs #28

chrisklus opened this issue Dec 30, 2019 · 0 comments

Comments

@chrisklus
Copy link
Contributor

chrisklus commented Dec 30, 2019 •
edited
Loading

For phetsims/tasks#1017.

There are 4 TODOs in binder without an associated issue. All four are either pointing out recommended improvements or possible weaknesses, so I'm linking them here to be tracked.

With the transition of binder to be built with react in #26, I'm not sure how many of these will still be relevant and need or work or be replaced/not needed. Leaving unassigned until the relevance of this code is determined.
chrisklus added a commit that referenced this issue Dec 30, 2019
@chrisklus
Tag TODOs without an issue, see #28
b86ad68
zepumph added a commit that referenced this issue Feb 15, 2021
@zepumph
fix path, #28
04a7561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisklus