Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometric Optics visual difference #6

Open
jonathanolson opened this issue Oct 14, 2023 · 1 comment
Open

Geometric Optics visual difference #6

jonathanolson opened this issue Oct 14, 2023 · 1 comment
Assignees
@jonathanolson @marlitas
Labels
type:bug Something isn't working

Comments

@jonathanolson
Copy link
Contributor

(Moderate difficulty, somewhat related to #5, but hopefully slightly easier to track down)

Run things similar to #5, but with geometric-optics. First screen.

Scenery SVG:
image

Alpenglow:
image

(as a side note... check out the antialiasing differences on the black line between the two! some is going on with Chrome SVG)
@jonathanolson jonathanolson added the type:bug Something isn't working label Oct 14, 2023
@jonathanolson
Copy link
Contributor Author

(moderate difficulty)

Miter-limit issue on the lens (look up miterlimit!)

Scenery SVG:
image

Alpenglow:
image

This might be related to Kite's shape stroking (that we're using for now). Is getStrokedShape() not respecting miterlimit correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

@marlitas marlitas

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @marlitas