Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate driver from UDBC-SQLite3 to Pharo-SQLite3 #1

Open
PierceNg opened this issue Nov 24, 2019 · 6 comments
Open

Migrate driver from UDBC-SQLite3 to Pharo-SQLite3 #1

PierceNg opened this issue Nov 24, 2019 · 6 comments

Comments

@PierceNg
Copy link
Contributor

As subject.

@eMaringolo
Copy link

I don't know who is the admin of the repo, but can we create an udbc tag, so we can continue committing in the master branch but using Pharo-SQLite3 instead of the UDBC version?

@astares
Copy link
Contributor

astares commented Apr 4, 2020

There is no admin: it's a community repo, see https://github.com/orgs/pharo-rdbms/people

You can join and help if you like

@PierceNg
Copy link
Contributor Author

Did the following:

  • Updated p7_newsqlite branch. This branch now works with Pharo-SQLite3 on Pharo 7. One blob test fails.

Plan to do the following:

  • Update p7_udbc branch to load UDBC-SQLite3 from Github not Smalltalkhub.
  • Test p7_newsqlite branch with Pharo 8.
  • Make p7_newsqlite branch the new master upon successful testing with Pharo 8.

When done, p7_udbc will be the legacy UDBC version, tested with Pharo 7, and master will be use Pharo-SQLite3 going forward.

Thoughts?

@eMaringolo
Copy link

I think we should start using version tags, so in the future the dependency could be made on a particular tag, and that would give us the freedom to move forward without breaking references to the head (implicit) of a particular branch.

@astares
Copy link
Contributor

astares commented Apr 27, 2020

Yes - I guess we could try in separate branches, but keep the master as "master" and tag it with releases. Similar to other projects. And I doubt people will have a problem migrating since the changes are straightforward.

@eMaringolo
Copy link

We can have an udbc branch from the last udbc based commit and let people know about it (just in case somebody wants to continue using it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants