Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle known architectures with case statement #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Handle known architectures with case statement #33

wants to merge 3 commits into from

Conversation

theseion
Copy link

Added a case statement that checks for known architecture variants. Will also assign UNKNOWN to the variable, similar to the OSNAME variable.

Fixes #32

@theseion theseion mentioned this pull request May 26, 2021
Open
@theseion
Copy link
Author

Since there are no more 32-bit VMs for Pharo 9+ there is no need to generate 32-bit architecture file names. However, the variable VM_ARCH is now handled the same way as OSNAME and will fallback to and UNKNOWN value for unknown architectures.

@theseion theseion changed the title Handle 32-bit architectures as well Handle known architectures with case statement May 26, 2021
@theseion theseion mentioned this pull request May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppVeyor builds for Pharo on Windows fail because there's no i686 architecture
1 participant
@theseion