Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8 reporter doesn't output when no states option is passed in #215

Open
jlafaytfg opened this issue Nov 15, 2024 · 1 comment · May be fixed by #216
Open

v8 reporter doesn't output when no states option is passed in #215

jlafaytfg opened this issue Nov 15, 2024 · 1 comment · May be fixed by #216

Comments

@jlafaytfg
Copy link

In 7.1.0, the _transform handler would return early when options.states is set and file.s3.state was not found in options.states.

In the latest version, there isn't a check to see if states is passed in. So it ends up being an empty array that's used to create an allowedStates that is also now empty. There should be a check to see if allowedStates has values included with the allowedStates.has(file.s3.state) check before deciding to return early.
jlafaytfg added a commit to jlafaytfg/gulp-awspublish that referenced this issue Nov 15, 2024
@jlafaytfg
Update log-reporter.js
661286a 
Fixes pgherveou#215 by checking that states were passed in for filtering and allow for defaulting to logging all states.
@jlafaytfg jlafaytfg linked a pull request Nov 15, 2024 that will close this issue
Open
@jlafaytfg
Copy link
Author

Added a PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jlafaytfg