Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the options so that users can customize their cache key generation if they really need it. #31

Open
Nilabhra opened this issue Mar 7, 2023 · 0 comments
Assignees
Labels
tuunv2 For the support of TuunV2

Comments

@Nilabhra
Copy link
Collaborator

Nilabhra commented Mar 7, 2023

          >> It'll be better if there is a default way to generate the cache key since it is not natural that users must configure how to generate the cache key after they set cache=True. But it makes sense to expose the options so that users can customize their cache key generation if they really need it.

For example, if cache=True, then the cache key will be associated with the function signature and parameter values. But users can choose which parameter value to ignore.

I totally agree with this but it might take a while to get this working. How about we create an issue and resolve this in a separate PR?

@nikhilranjan7 Sure. Let's create an issue to keep track of this after this PR is merged.

Originally posted by @zhanyuanucb in #27 (comment)

@Nilabhra Nilabhra changed the title >> It'll be better if there is a default way to generate the cache key since it is not natural that users must configure how to generate the cache key after they set cache=True. But it makes sense to expose the options so that users can customize their cache key generation if they really need it. Expose the options so that users can customize their cache key generation if they really need it. Mar 7, 2023
@Nilabhra Nilabhra self-assigned this Mar 7, 2023
@Nilabhra Nilabhra added the tuunv2 For the support of TuunV2 label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tuunv2 For the support of TuunV2
Projects
None yet
Development

No branches or pull requests

1 participant