Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for article page #1

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Fix for article page #1

merged 3 commits into from
Oct 27, 2024

Conversation

petercr
Copy link
Owner

@petercr petercr commented Oct 27, 2024

✨ Codu Pull Request 💻

Fixes
It is related to issue codu-code#1168 and E2E testing, but more importantly it fixes an issue on the articles page which would not load the corresponding article without crashing.

Pull Request details

  • I tried to view /articles and then click the corresponding link.
  • The Next web server would crash with error: can't resolve module @tiptap/html
  • I fixed the import issues with tiptap/html
  • I then added the types for the isomorphic-dompurify package
  • Manual testing confirms the feature is now working.

Any Breaking changes

None.

Associated Screenshots

Screenshot of the issue now resolved with current PR:
Screenshot_26-10-2024_121041_localhost

@petercr petercr merged commit f31e884 into develop Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant