Fix in-memory queue using shared-cache #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-wangxu
force-pushed
the
memory_shared_cache
branch
from
a018857
to
d266b2c
Compare
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 93.4% 92.71% -0.69%
==========================================
Files 6 6
Lines 394 398 +4
Branches 48 48
==========================================
+ Hits 368 369 +1
- Misses 11 16 +5
+ Partials 15 13 -2
Continue to review full report at Codecov.
|
peter-wangxu
force-pushed
the
memory_shared_cache
branch
2 times, most recently
from
6cd79ad
to
dc576f4
Compare
When share in-memory queue in multi-thread, the queue is not properly synced between threads, this commit uses shared-cache to achieve the synchronization. fixes #31
peter-wangxu
force-pushed
the
memory_shared_cache
branch
3 times, most recently
from
39d1e3f
to
e74130f
Compare
peter-wangxu
force-pushed
the
memory_shared_cache
branch
from
e74130f
to
540e0e6
Compare
|
Reopen it if in-memory sqlite queue is needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When share in-memory queue in multi-thread, the queue is not
properly synced between threads, this commit uses shared-cache
to achieve the synchronization.
fixes #31