ibc: fix reversed misbehavior handling condition #4807
Labels
A-IBC
Area: IBC integration with Penumbra
C-bug
Category: a bug
needs-refinement
unclear, incomplete, or stub issue that needs work
_P-medium
Medium priority
_P-V2
Priority: after mainnet
IBC-GO
assumes that in the misbehavior messageheader1
is at a greater height thanheader2
and enforces this ordering. A misbehavior is considered valid ifheader1
's timestamp is not greater thanheader2
s timestamp:https://github.com/cosmos/ibc-go/blob/main/modules/light-clients/07-tendermint/misbehaviour_handle.go#L75
Our misbehavior handling has this condition reversed,
header1
is expected to be at a lower height thanheader2
and it is a misbehavior ifheader1
s timestamp is greater thanheader2
's timestamp:https://github.com/penumbra-zone/penumbra/blob/release/v0.80.x/crates/core/component/ibc/src/component/msg_handler/misbehavior.rs#L177
This method of submitting misbehaviors is deprecated and should not be used, but if someone does use it, valid submissions will be blocked. Misbehaviors can still be submitted and acknowledged through the standard update handler, which is recommended.
We can and should still fix this, so that the deprecated path still works as expected.
The text was updated successfully, but these errors were encountered: