Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Dart Sass #495

Open
faraixyz opened this issue Mar 4, 2021 · 5 comments
Open

Integrate Dart Sass #495

faraixyz opened this issue Mar 4, 2021 · 5 comments
Assignees
Labels
proposal Feature request

Comments

@faraixyz
Copy link

faraixyz commented Mar 4, 2021

Is your feature request related to a problem? Please describe.

From 0.80, Hugo has dart sass support, but it needs dart sass embedded.

Describe the solution you'd like

Including dart sass embedded in the action, but it needs to be done carefully because the different versions have their compatibility issues.

Describe alternatives you've considered

Doing it in the workflow definition.

Additional context

Add any other context or screenshots about the feature request here.

@faraixyz faraixyz added the proposal Feature request label Mar 4, 2021
@peaceiris
Copy link
Owner

Thank you for your suggestion! ʕ◔ϖ◔ʔ

When I saw the Hugo v0.80.0 first, I thought about this option, me too. According to the documentation, Hugo seems to have a plan to bind the Embedded Dart Sass as the same as LibSass (Hugo extended). I expect that the improvement will be done at bep/godartsass.

The transpiler to use, valid values are libsass (default) and dartsass. Note that the Embedded Dart Sass project is still in beta (beta 5 at the time of writing). The release is scheduled for Q1 2021. We will try to improve the installation process by then, but if you want to use Hugo with Dart Sass you need to download a release binary from Embedded Dart Sass (Hugo after 0.81.0 requires beta 6 or newer) and make sure it’s in your PC’s $PATH (or %PATH% on Windows).

https://gohugo.io/hugo-pipes/scss-sass/#options

The plan looks worth the wait.

@faraixyz
Copy link
Author

faraixyz commented Mar 4, 2021

That's cool. Thanks for making this project.

@peaceiris
Copy link
Owner

peaceiris commented Mar 4, 2021

I also have opened a related issue in gohugoio/hugo: Binding Embedded Dart Sass into Hugo · Issue #8299 · gohugoio/hugo

@peaceiris peaceiris pinned this issue Mar 5, 2021
@peaceiris
Copy link
Owner

We cannot (I'm probably sure about that) embed this into Hugo's binary (the embedded files in Go 1.16 is not executable).

gohugoio/hugo#8299 (comment)

We found that the installation of the Embedded Dart Sass should be handled by this action. I will work on this! ʕ◔ϖ◔ʔ

@domw95
Copy link

domw95 commented Jul 28, 2024

For anyone needing Dart Sass in Github actions: https://github.com/marketplace/actions/dart-sass
Its fairly basic but might be useful for some

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Feature request
Projects
None yet
Development

No branches or pull requests

3 participants