Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WorkInProgress] [#247] [spark] Bump Spark Version to 2.4.7 #249

Closed
wants to merge 15 commits into from
Closed

[WorkInProgress] [#247] [spark] Bump Spark Version to 2.4.7 #249

wants to merge 15 commits into from

Conversation

Dee-Pac
Copy link
Contributor

@Dee-Pac Dee-Pac commented Oct 30, 2020 •
edited
Loading

Make sure you have checked all steps below.

GitHub Issue

Fixes #247

  • NOT READY FOR MERGE
  • PUSHED COMMITS ARE READY FOR REVIEW

Checklist:

  • This pull request updates the documentation
  • This pull request changes library dependencies
  • Title of the PR is of format (example) : [[Github] Add Pull Request Template #25][Github] Add Pull Request Template

What is the purpose of this pull request?

  • Trims Spark Logging module that had multiple versions bundled.
  • Deprecates prior Kafka versions
  • Cleans-up the repo
  • Mainly, bumps up the spark version
  • Improves documentation

How was this change validated?

  • Testing in progress

Commit Guidelines

  • My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@Dee-Pac Dee-Pac changed the title [][#247] [spark] Bump Spark Version to 2.4.7 | Trim Logging Module [WorkInProgress] [#247] [spark] Bump Spark Version to 2.4.7 | Trim Logging Module Oct 30, 2020
@Dee-Pac Dee-Pac added dependencies Pull requests that update a dependency file docs Creation or updates to documentation, how to's, and more Enhancement New feature or request Version Upgrade labels Oct 30, 2020
@Dee-Pac Dee-Pac changed the title [WorkInProgress] [#247] [spark] Bump Spark Version to 2.4.7 | Trim Logging Module [WorkInProgress] [#247] [spark] Bump Spark Version to 2.4.7 Oct 30, 2020
sathishsri88
sathishsri88 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@sathishsri88 sathishsri88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As most of the changes are bumping up of the spark version and cleanup of files. Changes looks good to me

@Dee-Pac Dee-Pac force-pushed the issue-247 branch 2 times, most recently from be78fa3 to 101ad94 Compare November 6, 2020 10:32
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
f54b1a1 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
295fedb 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
e957499 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac Dee-Pac force-pushed the issue-247 branch 2 times, most recently from f1e20d1 to cc228a9 Compare November 7, 2020 01:20
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
a83d31f 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
c4b6716 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
219fc00 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
3b25dcb 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
7e5f21e 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac Dee-Pac force-pushed the issue-247 branch 2 times, most recently from f0f0049 to 7e5f21e Compare November 9, 2020 02:12
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Remove modules [sq…
51ca21b 
…l, tools, examples, connector/hbase , connector/druid]
@Dee-Pac Dee-Pac force-pushed the issue-247 branch 5 times, most recently from 7290ba8 to 6f59fdc Compare November 9, 2020 13:19
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
a75a05e 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
6e3ae2f 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac
[paypal#247] [spark] Bump Spark Version to 2.4.7 | Bump Spark Version…
47a79fe 
… to 2.4.7 along with other stack to align with gcp_dataproc_1.5.x
@Dee-Pac Dee-Pac closed this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sathishsri88 sathishsri88 sathishsri88 approved these changes

@AbhishekChinni AbhishekChinni AbhishekChinni approved these changes

@anishanainani anishanainani Awaiting requested review from anishanainani

@bagopalan bagopalan Awaiting requested review from bagopalan

@bthilakraj bthilakraj Awaiting requested review from bthilakraj

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file docs Creation or updates to documentation, how to's, and more Enhancement New feature or request Version Upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spark] Bump Spark Version to 2.4.7
3 participants
@Dee-Pac @sathishsri88 @AbhishekChinni