Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManualInstruction should abort the transformation if it fails for any reason #259

Open
fabiocarvalho777 opened this issue Oct 17, 2018 · 0 comments

Comments

@fabiocarvalho777
Copy link
Member

fabiocarvalho777 commented Oct 17, 2018

Currently, If the MD file does not exist, the ManualInstruction TU results in ERROR, but does not abort the transformation.

However, that by itself is a major error, because the end user won't have a chance to complete that manual instruction.

Having said that, Butterfly must abort the transformation whenever ManualIsntruction fails by default (for whatever reason).

That should be documented properly in ManualInstruction javadoc, and the developer should still have a chance to change this behavior by calling abortOnFailure(false).

In addition to that, it must fail fast in the case of an inexistent MD file (check it during definition time, as opposed to transformation time).

Acceptance Criteria

  1. ManualInstruction by default must abort the transformation if it fails for whatever reason
  2. Developer must have a chance to change this behavior by calling abortOnFailure(false)
  3. In the case of an inexistent MD file, it must fail fast (check it during definition time, as opposed to transformation time)
  4. Make sure all of this is documented completely and clearly in the contract (javadoc)
@fabiocarvalho777 fabiocarvalho777 added this to the 3.0.0 milestone Oct 17, 2018
@fabiocarvalho777 fabiocarvalho777 removed this from the 3.0.0 milestone Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant