Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select All button in list view will delete all docs including locked docs #8783

Closed
PatrikKozak opened this issue Oct 18, 2024 · 3 comments · Fixed by #8813
Closed

Select All button in list view will delete all docs including locked docs #8783

PatrikKozak opened this issue Oct 18, 2024 · 3 comments · Fixed by #8813

Comments

@PatrikKozak
Copy link
Contributor

PatrikKozak commented Oct 18, 2024

Describe the Bug

When selecting the toggle all checkbox in the list view of a collection - the select all button will render in the top right which allows the selection of all documents that may exist on another page instead of just the ones on the current page.

The toggle all properly ignores locked documents on the current page but the select all does not - therefore allowing to delete, edit, unpublish etc all documents including ones that are currently locked.

Screen.Recording.2024-10-18.at.11.11.25.AM.mov

Link to the code that reproduces this issue

pnpm dev locked-documents

Reproduction Steps

  1. pnpm dev locked-documents

  2. Create 6+ posts in the posts collection

  3. Change the list view scope to only show 5 docs per page

  4. Have a separate user start editing on the docs on the second page to lock a doc on a separate page

  5. Click the toggle all checkbox input as the initial user

  6. In the top right, click the select all docs button

  7. Delete all docs with the delete button

  8. Watch all docs get deleted - including the locked ones

Expectation: Locked documents should be ignored.

Which area(s) are affected? (Select all that apply)

area: ui

Environment Info

Payload: v3.0.0-beta.116

@PatrikKozak
Copy link
Contributor Author

Fixed with #8813

Copy link

🚀 This is included in version v3.0.0-beta.117

Copy link

This issue has been automatically locked.
Please open a new issue if this issue persists with any additional detail.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant