Merge CLI flags with flags found in config file. #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the desired behavior is to merge these flags so that users can specify both CLI flags and a config file simultaneously. As it stands, when a config file is specified, it's flags will replace (and erase) any flags passed through CLI.
Note, I had to upgrade Typescript by a few minor versions because I was getting a TS build error
Cannot find name 'Omit'., and I saw that TS 3.0 didn't support it. So I bumped TS to 3.5 and everything seemed to be working. We'll see what travis says.Fixes #150.