Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong annotations for DenseInfos #399

Closed
Randl opened this issue Apr 14, 2024 · 0 comments · Fixed by #400
Closed

Wrong annotations for DenseInfos #399

Randl opened this issue Apr 14, 2024 · 0 comments · Fixed by #400

Comments

@Randl
Copy link
Contributor

Randl commented Apr 14, 2024

DenseInfos are defined of shape times

DenseInfos = dict[str, PyTree[Shaped[Array, "times ..."]]]

While in fact it probably should be times+1:

assert _infos.shape[0] + 1 == self.ts.shape[0]

dense_ts = jnp.full(max_steps + 1, jnp.inf, dtype=time_dtype)
_make_full = lambda x: jnp.full(
(max_steps,) + jnp.shape(x), jnp.inf, dtype=x.dtype
)
dense_infos = jtu.tree_map(_make_full, dense_info)

As such global interpolation tests fail, e.g., see #391 but also locally on master

It is possibly related to some update, maybe of jaxtyping (this PR is on the new Lineax version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant