Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multiple Aggregation Dimensions #75

Open
jrweinb opened this issue May 11, 2018 · 10 comments
Open

Support Multiple Aggregation Dimensions #75

jrweinb opened this issue May 11, 2018 · 10 comments

Comments

@jrweinb
Copy link

jrweinb commented May 11, 2018

It would be great to have the type of functionality seen in this Pivot component:

Webix Pivot Component

Here, both GDP and OIL are aggregation dimensions, with configurable aggregators. I tried forking the library and working on it on my own, but I was unable to get it working on first pass. Any suggestions or recommendations on where to focus? Thanks!

@pat310
Copy link
Owner

pat310 commented May 12, 2018

Most of the business logic is located in src/logic, so that's likely where you would poke around. Is it possible to do the configurable aggregators using the callback function? You have access to each of the aggregation fields in that callback function so you could configure any aggregations that you wanted

@jrweinb
Copy link
Author

jrweinb commented May 14, 2018

@pat310 Thanks for your input! So I am able to use the callback function to do exactly what you suggest, but the results are hard to understand when rendered without column headers (from a UX perspective). Its definitely a workable solution, but I would prefer to create a feature where you could give an array of aggregation dimensions and a flag to show/hide column headers for each aggregation.

I am currently working on adding the new columns in createColumnHeaders and I will see where that gets me.

@jrweinb
Copy link
Author

jrweinb commented May 21, 2018

@pat310 - I got this working, but I need to do a lot of refactoring and test writing before I would submit a PR. It accepts an array of aggregationDimensions and create column headers for each aggregation under its parent. Below is a rendering of my pivot table, where the input array of aggDimensions is: ['value1', 'value2']

screen shot 2018-05-21 at 5 21 51 pm

I am also going to work on different types of aggregations for each aggregation dimension once this is complete. I will send another update when I have made more progress

@pat310
Copy link
Owner

pat310 commented May 22, 2018 via email

@rmdort
Copy link

rmdort commented Aug 7, 2018

@jrweinb Looks really good. Any possibility of having this feature merged?

@pat310
Copy link
Owner

pat310 commented Aug 8, 2018

If a PR is made for it, I'll merge it in

@rmdort
Copy link

rmdort commented Aug 9, 2018

@jrweinb Do you have fork of a working version that supports multiple agg? Care to share?

@fmq
Copy link

fmq commented Jun 13, 2019

@jrweinb I know it's old now but could you share your code for this? I have to code the same functionality and it would be great to have your code to Strat from

Thanks!

@lovelyelfpop
Copy link

@jrweinb Could you share your code, please? Thank you

@Gydunhn
Copy link

Gydunhn commented Aug 26, 2020

@jrweinb @fmq I have to code the same functionality too!, any news ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants