Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API Availability Checks instead of PF_UNAVAILABLE_WARNING #1788

Open
4 tasks done
JohnCaccavale opened this issue May 4, 2024 · 1 comment
Open
4 tasks done
Labels
type:feature New feature or improvement of existing feature

Comments

@JohnCaccavale
Copy link
Contributor

Issue Description

Some classes and API are unavailable for all platforms. In some cases, to indicate a particular class is unavailable, various macros are used such as PF_OSX_UNAVAILABLE_WARNING, PF_TV_UNAVAILABLE_WARNING, PF_WATCH_UNAVAILABLE_WARNING, etc.

This unfortunately results in unnecessary warnings in the Xcode Issue Navigator even if a client project makes no use of those API.

Screenshot 2024-05-04 at 5 35 18 PM

Rather than generating these warnings, these macros should be removed in favor of @available API checks.

Steps to reproduce

  • Create a macOS project and add the latest Parse SDK as a dependency via Swift Package Manager.
  • Upon building the macOS project, the warnings appear in the issue navigator.

Actual Outcome

  • Warnings appear in the issue navigator that need not to occur.

Expected Outcome

  • If not utilizing unavailable API, there should be no project warnings.

Environment

  • ParseObjc Version 3.0.0
  • Xcode Version 15.3 (15E204a)

Client

  • Parse ObjC SDK version: 3.0.0
Copy link

Thanks for opening this issue!

@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

2 participants