Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove substrate-compat feature #1847

Open
niklasad1 opened this issue Oct 29, 2024 · 0 comments · May be fixed by #1850
Open

remove substrate-compat feature #1847

niklasad1 opened this issue Oct 29, 2024 · 0 comments · May be fixed by #1850

Comments

@niklasad1
Copy link
Member

niklasad1 commented Oct 29, 2024

subxt has a feature called substrate-compat which provides a few nice impls/features from polkadot-sdk such as:

  • polkadot sdk signer
  • Glue code for seamless conversions between subxt types and polkadot-sdk types such as AccountId32 and similar

This comes with the downside that subxt depends on polkadot-sdk which is brings in lots of dependencies and that subxt is dependent of the polkadot-sdk releases such as i) if there is no subxt release for a while it may use an outdated polkadot-sdk version ii) that a specific user wants to use a specific release iii) the code doesn't compile with different versions of some dependency.

In addition, subxt got a lot of issues where folks have issues with a certain polkadot-sdk release/branch and this will allow users to select which polkadot-sdk release/branch would makes this easier. Of course to some degree subxt is dependent to polkadot-sdk such new transaction extensions, signed extensions and similar things.

So the idea is that subxt will remove this feature, the user has to bring these dependencies themselves

It's important that subxt provides a nice and easy example how to do this without the subxt substrate-compat feature.

@niklasad1 niklasad1 linked a pull request Nov 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant