Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Improve error handling #1

Open
kianenigma opened this issue Feb 12, 2019 · 1 comment
Open

Improve error handling #1

kianenigma opened this issue Feb 12, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@kianenigma
Copy link
Collaborator

Currently, there are two panic!s and one except() in the Rust code. They should be removed. Consequently, the entire interface could -> should be replaced with returning Result<T, JsVal>.

https://rustwasm.github.io/wasm-bindgen/reference/attributes/on-js-imports/catch.html
@kianenigma kianenigma added the enhancement New feature or request label Feb 12, 2019
@kianenigma
Copy link
Collaborator Author

will be fixed in when #4 is merged.

kianenigma added a commit that referenced this issue Feb 15, 2019
@kianenigma
test using result instead of no panic! #1
ec1da79
kianenigma added a commit that referenced this issue Feb 15, 2019
@kianenigma
finalize error handling #1
ddb7e86
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kianenigma