Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pallets to V2 bench syntax #6202

Open
20 of 44 tasks
ggwpez opened this issue Oct 23, 2024 · 17 comments
Open
20 of 44 tasks

Refactor pallets to V2 bench syntax #6202

ggwpez opened this issue Oct 23, 2024 · 17 comments
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@ggwpez
Copy link
Member

ggwpez commented Oct 23, 2024 •
edited by re-gius
Loading

We should move all remaining pallets to the V2 benchmarking syntax. It seems to be stable and feature complete.

👉 If you want to work on this: Please check that there is not already a merge request for the pallet that you want to work on. Please pick only one or a small set of pallets - not all at once. This keeps review times low.

Full pallet list:

Then the Polkadot and Cumulus pallets:

  • ./cumulus/pallets/session-benchmarking/src/inner.rs
  • ./polkadot/xcm/pallet-xcm-benchmarks/src/generic/benchmarking.rs
  • ./polkadot/xcm/pallet-xcm/src/benchmarking.rs
  • ./polkadot/runtime/common/src/claims.rs Refactor pallet claims #6318
  • ./polkadot/runtime/common/src/crowdloan/mod.rs
  • ./polkadot/runtime/common/src/paras_registrar/mod.rs
  • ./polkadot/runtime/common/src/auctions.rs
  • ./polkadot/runtime/common/src/slots/mod.rs
  • ./polkadot/runtime/parachains/src/initializer/benchmarking.rs
  • ./polkadot/runtime/parachains/src/configuration/benchmarking.rs
  • ./polkadot/runtime/parachains/src/paras_inherent/benchmarking.rs
  • ./polkadot/runtime/parachains/src/inclusion/benchmarking.rs
  • ./polkadot/runtime/parachains/src/disputes/benchmarking.rs
  • ./polkadot/runtime/parachains/src/disputes/slashing/benchmarking.rs
  • ./polkadot/runtime/parachains/src/paras/benchmarking.rs
@ggwpez ggwpez added I4-refactor Code needs refactoring. T12-benchmarks This PR/Issue is related to benchmarking and weights. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Oct 23, 2024
@ggwpez ggwpez changed the title Migrate all pallets to benchmarking V2 syntax Refactor pallets to V2 bench syntax Oct 23, 2024
@ggwpez ggwpez mentioned this issue Oct 23, 2024
Open
@AurevoirXavier
Copy link
Contributor

AurevoirXavier commented Oct 28, 2024 •
edited
Loading

Some updates:

This was referenced Oct 28, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024
@AurevoirXavier
Migrate pallet-vesting benchmark to v2 (#6254)
1497635 
Part of:

- #6202.
github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024
@AurevoirXavier @seadanda
Migrate pallet-timestamp benchmark to v2 (#6258)
80cd5fd 
Part of:

- #6202

---------

Co-authored-by: Dónal Murray <[email protected]>
This was referenced Oct 29, 2024
Merged
Open
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@AurevoirXavier @mordamax
Migrate pallet-vesting benchmark to v2 (paritytech#6254)
1819d89 
Part of:

- paritytech#6202.
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@AurevoirXavier @seadanda @mordamax
Migrate pallet-timestamp benchmark to v2 (paritytech#6258)
dee9777 
Part of:

- paritytech#6202

---------

Co-authored-by: Dónal Murray <[email protected]>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@AurevoirXavier @mordamax
Migrate pallet-vesting benchmark to v2 (paritytech#6254)
65ee481 
Part of:

- paritytech#6202.
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@AurevoirXavier @seadanda @mordamax
Migrate pallet-timestamp benchmark to v2 (paritytech#6258)
b41419a 
Part of:

- paritytech#6202

---------

Co-authored-by: Dónal Murray <[email protected]>
@programskillforverification
Copy link
Contributor

programskillforverification commented Oct 30, 2024 •
edited
Loading

Pick up:

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024
@AurevoirXavier @seadanda
Migrate pallet-utility to benchmark v2 (#6276)
06debd0 
Part of:

- #6202.

---------

Co-authored-by: Dónal Murray <[email protected]>
@clangenb
Copy link
Contributor

clangenb commented Oct 30, 2024 •
edited
Loading

Pickup:

@AurevoirXavier
Copy link
Contributor

Pickup:

  • pallet-remark, pallet-scheduler

Hi, I'm working scheduler currently. :)

@clangenb
Copy link
Contributor

Thanks for the quick response 🚀

Merged
@clangenb clangenb mentioned this issue Oct 30, 2024
Merged
@clangenb
Copy link
Contributor

clangenb commented Oct 30, 2024 •
edited
Loading

Pickup:

@AurevoirXavier
Copy link
Contributor

Pick up:

  • transaction-storage, indices
  • babe, child-bounties, democracy
  • fast-unstake, glutton

Well... I recommend handling them individually and providing updates here, rather than claiming them all at once.

This was referenced Oct 30, 2024
Open
Open
Open
This was referenced Oct 31, 2024
Merged
Merged
Merged
@re-gius re-gius mentioned this issue Nov 1, 2024
Merged
2 tasks
@re-gius
Copy link
Contributor

re-gius commented Nov 1, 2024

Working on pallet-claims in #6318

github-merge-queue bot pushed a commit that referenced this issue Nov 4, 2024
@re-gius @gui1117
Refactor pallet claims (#6318)
657b550 
- [x] Removing `without_storage_info` and adding bounds on the stored
types for pallet `claims` - issue
#6289
- [x] Migrating to benchmarking V2 -
#6202

---------

Co-authored-by: Guillaume Thiolliere <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Nov 4, 2024
@AurevoirXavier @actions-user
@ggwpez @seadanda @re-gius
Migrate pallet-glutton benchmark to v2 (#6296)
f4ded5c 
Part of:

- #6202.

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Giuseppe Re <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Nov 4, 2024
@AurevoirXavier @actions-user
@gui1117 @ggwpez
Migrate pallet-election-provider-multi-phase benchmark to v2 and impr…
9353a28 
…ove doc (#6316)

Part of:

- #6202.

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Guillaume Thiolliere <[email protected]>
Co-authored-by: Guillaume Thiolliere <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Nov 4, 2024
@clangenb @actions-user @ggwpez
migrate pallet-recovery to benchmark V2 syntax (#6299)
b1084e7 
Part of:
* #6202

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Nov 5, 2024
@clangenb @ggwpez
@actions-user @re-gius
migrate pallet-remarks to v2 bench syntax (#6291)
3c6ea86 
Part of:
* #6202

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Giuseppe Re <[email protected]>
@re-gius re-gius mentioned this issue Nov 5, 2024
Merged
2 tasks
@re-gius
Copy link
Contributor

re-gius commented Nov 5, 2024

Working on pallet-society in #6367

github-merge-queue bot pushed a commit that referenced this issue Nov 5, 2024
@AurevoirXavier @actions-user @re-gius
Migrate pallet-im-online benchmark to v2 (#6295)
8b6c6eb 
Part of:

- #6202.

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Giuseppe Re <[email protected]>
@clangenb
Copy link
Contributor

clangenb commented Nov 6, 2024 •
edited
Loading

Pickup:

Edit: Sorry I haven't seen that you were on fast-unstake: @programskillforverification. Feel free to incorporate my PRs changes into your branch, mine would be finished, and I don't want to snatch work from you.

@clangenb clangenb mentioned this issue Nov 6, 2024
Closed
@clangenb
Copy link
Contributor

clangenb commented Nov 6, 2024 •
edited
Loading

Pickup:

@clangenb clangenb mentioned this issue Nov 6, 2024
Open
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
@AurevoirXavier @actions-user
@gui1117 @re-gius
Migrate pallet-election-provider-support-benchmarking benchmark to v2 (…
1d351bf 
…#6315)

Part of:

- #6202.

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Guillaume Thiolliere <[email protected]>
Co-authored-by: Giuseppe Re <[email protected]>
Co-authored-by: Guillaume Thiolliere <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
@AurevoirXavier @re-gius @actions-user
Migrate pallet-elections-phragmen benchmark to v2 and improve doc (#6314
c4e94d3 
)

Part of:

- #6202.

---------

Co-authored-by: Giuseppe Re <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2024
@programskillforverification @re-gius @actions-user
Migrate pallet-transaction-storage and pallet-indices to benchmark v2 (…
edf79aa 
…#6290)

Part of:
#6202

---------

Co-authored-by: Giuseppe Re <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
@dharjeezy dharjeezy mentioned this issue Nov 9, 2024
Open
github-merge-queue bot pushed a commit that referenced this issue Nov 11, 2024
@clangenb @re-gius
@actions-user @bkchr
migrate pallet-nft-fractionalization to benchmarking v2 syntax (#6301)
aff3a07 
Migrates pallet-nft-fractionalization to benchmarking v2 syntax.

Part of:
* #6202

---------

Co-authored-by: Giuseppe Re <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Nov 12, 2024
@AurevoirXavier @actions-user @re-gius
Migrate pallet-child-bounties benchmark to v2 (#6310)
b570baf 
Part of:

- #6202.

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Giuseppe Re <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2024
@re-gius @gui1117 @muharem
Refactor pallet society (#6367)
e87bffc 
- [x] Removing `without_storage_info` and adding bounds on the stored
types for pallet `society` - issue
#6289
- [x] Migrating to benchmarking V2 -
#6202

---------

Co-authored-by: Guillaume Thiolliere <[email protected]>
Co-authored-by: Muharem <[email protected]>
@kianenigma
Copy link
Contributor

Great work being done around all PRs made here. Thank you to all contributors, and thank you @re-gius for coordinating.

  1. All of these PRs can be merged with Silent tag as they are backwards compat.
  2. @re-gius please reward those who work on this and provide a DOT address with a /tip small.

@re-gius
Copy link
Contributor

re-gius commented Nov 15, 2024

  1. @re-gius please reward those who work on this and provide a DOT address with a /tip small.

I'm checking all the merged PRs and rewarding with /tip small one in two for each user (as @shawntabrizi started doing).

@clangenb
Copy link
Contributor

clangenb commented Nov 15, 2024 •
edited
Loading

Pickup:

@clangenb clangenb mentioned this issue Nov 15, 2024
Open
github-merge-queue bot pushed a commit that referenced this issue Nov 15, 2024
@clangenb @actions-user
@gui1117 @re-gius
migrate pallet-nomination-pool-benchmarking to benchmarking syntax v2 (…
4df9433 
…#6302)

Migrates pallet-nomination-pool-benchmarking to benchmarking syntax v2.

Part of:
* #6202

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Guillaume Thiolliere <[email protected]>
Co-authored-by: Giuseppe Re <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
Runtime / FRAME
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kianenigma @ggwpez @AurevoirXavier @clangenb @programskillforverification @re-gius