From<i64> impl is invalid

[benluelo]

This implementation is invalid:

parity-common/uint/src/uint.rs

Lines 1349 to 1356 in a5ef730

	impl $crate::core_::convert::From<i64> for $name {
	fn from(value: i64) -> $name {
	match value >= 0 {
	true => From::from(value as u64),
	false => { panic!("Unsigned integer can't be created from negative value"); }
	}
	}
	}

As per the docs on From:

Note: This trait must not fail. The From trait is intended for perfect conversions. If the conversion can fail or is not perfect, use TryFrom.

[benluelo]

From<i128> is also invalid:

parity-common/uint/src/uint.rs

Lines 487 to 494 in a5ef730

	impl $crate::core_::convert::From<i128> for $name {
	fn from(value: i128) -> $name {
	match value >= 0 {
	true => From::from(value as u128),
	false => { panic!("Unsigned integer can't be created from negative value"); }
	}
	}
	}

[ordian]

This initial impl predates the stabilization of TryFrom trait and should be replaced by that (breaking change) indeed nowadays.