Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Enable custom_sc_network feature #208

Open
lexnv opened this issue Aug 14, 2024 · 0 comments
Open

tests: Enable custom_sc_network feature #208

lexnv opened this issue Aug 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@lexnv
Copy link
Collaborator

lexnv commented Aug 14, 2024

Parts of our testing are guarded by "custom-sc-network", however cargo exposes custom_sc_network. This is a mismatch in feature naming.

#![cfg(feature = "custom-sc-network")]
#[cfg(test)]
mod connection;
#[cfg(test)]
mod notifications;
#[cfg(test)]
mod request_response;
#[cfg(test)]
mod websocket;

Further more, when enabling the feature its looks like the tests are using an outdated API and fail to compile

Discovered during: #207

@lexnv lexnv added the enhancement New feature or request label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant