Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Pool Management #126

Open
sbihel opened this issue Feb 11, 2023 · 1 comment
Open

Session Pool Management #126

sbihel opened this issue Feb 11, 2023 · 1 comment

Comments

@sbihel
Copy link
Contributor

sbihel commented Feb 11, 2023

Hi, this issue is just to say I wrote a session pool management crate based on r2d2: https://github.com/spruceid/r2d2-cryptoki.

I believe it's the right way of handling concurrent requests for service HSMs like cloud-hosted ones, but I thought maybe you'd have an opinion.

On a side note, I added a Zeroize wrapper for pins to ensure users understand how sensitive they are, and unless you think it's unnecessary I will create a PR as it would belong in this crate.

@ionut-arm
Copy link
Member

Hey! Thanks for the heads-up, the r2d2 crate does look pretty nice. I'm considering adding some links, perhaps on the README, to crates that have useful "3rd party" functionality. 🤔

In terms of a PR for zeroizing PINs - yes, please, that would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants