Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eviction latency metrics #6664

Open
Rjected opened this issue Feb 19, 2024 · 2 comments · May be fixed by #13946
Open

Add eviction latency metrics #6664

Rjected opened this issue Feb 19, 2024 · 2 comments · May be fixed by #13946
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-tx-pool Related to the transaction mempool C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@Rjected
Copy link
Member

Rjected commented Feb 19, 2024

Describe the feature

Each of the sub-pools have eviction routines:

reth/crates/transaction-pool/src/pool/parked.rs

Line 148 in 79f1fa3

pub fn truncate_pool(

reth/crates/transaction-pool/src/pool/blob.rs

Line 185 in 79f1fa3

pub(crate) fn truncate_pool(

reth/crates/transaction-pool/src/pool/pending.rs

Line 462 in 79f1fa3

pub fn truncate_pool(

There is also an overarching eviction routine:

reth/crates/transaction-pool/src/pool/txpool.rs

Line 757 in 79f1fa3

pub(crate) fn discard_worst(&mut self) -> Vec<Arc<ValidPoolTransaction<T::Transaction>>> {

Metrics for how long these routines take should be added

Additional context

No response
@Rjected Rjected added C-enhancement New feature or request A-tx-pool Related to the transaction mempool A-observability Related to tracing, metrics, logs and other observability tools labels Feb 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Mar 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Mar 18, 2024
@shekhirin shekhirin added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Mar 18, 2024
@shekhirin shekhirin reopened this Mar 18, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Reth Tracker Mar 18, 2024
@Rjected Rjected added the D-good-first-issue Nice and easy! A great choice to get started label Aug 2, 2024
@yohkaz yohkaz linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-tx-pool Related to the transaction mempool C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add latency metrics to eviction pools routines yohkaz/reth
2 participants
@shekhirin @Rjected