-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut down on reth-primitives::TransactionSigned usage #13631
Labels
A-sdk
Related to reth's use as a library
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
Comments
mattsse
added
C-enhancement
New feature or request
S-needs-triage
This issue needs to be labelled
labels
Jan 3, 2025
mattsse
added
D-good-first-issue
Nice and easy! A great choice to get started
A-sdk
Related to reth's use as a library
and removed
S-needs-triage
This issue needs to be labelled
labels
Jan 3, 2025
hi i can do it |
@hoank101 this task is kinda cursed, so I recommed doing this is very small chunks |
Can I take this issue? |
1 task
Gm gm! I would love to work on this! I have some experience in Rust and have contributed to projects like Starknet Foundry and dojo. This would be my first time contributing to Reth! |
Could I take on this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-sdk
Related to reth's use as a library
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
Describe the feature
This type will be deprecated as soon as possible
reth/crates/primitives/src/transaction/mod.rs
Line 786 in 82013f4
main blocker rn is that this type is still used excessively as default type, eg.
reth/crates/primitives/src/block.rs
Line 19 in 82013f4
and in testing.
TODO
we need to gradually replace usage of this type with the non-problematic ethereum specific type:
reth/crates/ethereum/primitives/src/transaction.rs
Line 260 in 82013f4
ideally on a crate by crate basis
Additional context
No response
The text was updated successfully, but these errors were encountered: