Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The function offsetGet raises a warning for PHP 8 #320

Open
meljturner opened this issue Mar 5, 2024 · 1 comment
Open

The function offsetGet raises a warning for PHP 8 #320

meljturner opened this issue Mar 5, 2024 · 1 comment

Comments

@meljturner
Copy link

There is an incompatibility with PHP 8.1.

Temporary fix is to add attribute:

#[\ReturnTypeWillChange]  at line 140 in Dom/Collection.php
@rgex
Copy link

rgex commented Mar 17, 2024

There are many issues with this library which isn't maintained anymore.
The only good news is that with PHP 8.4 we will get a decent native DOM parser in a couple of months.
https://wiki.php.net/rfc/domdocument_html5_parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgex @meljturner