Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new room last event filter #507

Open
WilsonLe opened this issue Jul 22, 2024 · 6 comments · May be fixed by pangeachat/matrix-dart-sdk#10 or #616
Open

use new room last event filter #507

WilsonLe opened this issue Jul 22, 2024 · 6 comments · May be fixed by pangeachat/matrix-dart-sdk#10 or #616
Assignees

Comments

@WilsonLe
Copy link

WilsonLe commented Jul 22, 2024

latest main of matrix sdk has implemented a new parameter in the class Client called shouldReplaceRoomLastEvent that receives 2 parameters: a current room last event, and a new current room last event and returns a boolean. You can implement custom logic on whether or not the new event should replace the current event.

@wcjord
Copy link

wcjord commented Aug 22, 2024

@ggurdin is this a good thing for us to implement now?

@ggurdin
Copy link
Collaborator

ggurdin commented Aug 22, 2024

Yes this would be good to implement now

@wcjord
Copy link

wcjord commented Aug 22, 2024

Ok please queue it up!

@wcjord
Copy link

wcjord commented Oct 1, 2024

@WilsonLe is this done? if not, potentially a good one for you.

@wcjord
Copy link

wcjord commented Nov 13, 2024

@WilsonLe What's going on with this ticket?

@wcjord wcjord assigned WilsonLe and unassigned ggurdin Nov 13, 2024
@ggurdin
Copy link
Collaborator

ggurdin commented Nov 14, 2024

@wcjord this pull request: pangeachat/matrix-dart-sdk#10 needs to go through before the client one can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants