Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests for JS components #2469

Open
samuelhwilliams opened this issue Jul 21, 2024 · 4 comments
Open

Add some tests for JS components #2469

samuelhwilliams opened this issue Jul 21, 2024 · 4 comments

Comments

@samuelhwilliams
Copy link
Contributor

We have a bunch of functionality that is in JavaScript, but nothing that really tests that side of the project. To prevent regressions, such as we've just seen with #2468, we should add some test coverage here.

This could either be direct JS tests, or something like Playwright that can do functional (browser) testing.

@hasansezertasan
Copy link
Member

This could either be direct JS tests, or something like Playwright that can do functional (browser) testing.

I think we should have less frontend code to maintain, meaning we can do browser testing 💯.

I have so little experience with Playwright. I did some scrapers and automation tools but nothing related to testing yet 🤔.

I believe we need this to prevent such regressions 🫡.

@samuelhwilliams
Copy link
Contributor Author

I haven't done much playwright either - I'm defo quite keen to have a play 👀

@hasansezertasan
Copy link
Member

I haven't done much playwright either - I'm defo quite keen to have a play 👀

I have a toy package called OpenAPIPages and I think it needs some browser-based testing 🚀.

I'll search for other packages that does browser-based testing to get inspired by. Let me know if you know/find any please 😇.

@hasansezertasan
Copy link
Member

I'll search for other packages that does browser-based testing to get inspired by. Let me know if you know/find any please 😇.

I have found two awesome projects that does browser-based testing using Selenium:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants