Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boss kill count messages send inconsistent image #577

Open
2 tasks done
harbingerofme opened this issue Oct 28, 2024 · 5 comments · May be fixed by #578
Open
2 tasks done

Boss kill count messages send inconsistent image #577

harbingerofme opened this issue Oct 28, 2024 · 5 comments · May be fixed by #578

Comments

@harbingerofme
Copy link

Checklist

Describe your issue

When hitting an interval, randomly an image of the boss will be attached to the message. This does not always get attached, nor is there a way to not send these at all. The size of them is inconsistent as well across different bosses.

Screenshots

Screenshot 2024-10-28 124838
Screenshot 2024-10-28 124931

Runelite Logs

client.log

Runelite Version

1.10.42.1

@Felanbird
Copy link
Member

Is there an icon in the top right of the first notif? I assume it's discord falling back because the first embed we intend to send is not being sent, and it's falling back to the second one, coming from the wiki link to Kraken.

Maybe you can also try changing %BOSS% in your notification message to <%BOSS%>? That would work in theory since <link_here> is how you send a link on discord without embed.

@iProdigy
Copy link
Member

The boss image is automatically added as a rich embed if you disabled screenshots (and a matching NPC with the given name could be found): https://github.com/pajlads/DinkPlugin/blob/v1.10.12/src/main/java/dinkplugin/notifiers/KillCountNotifier.java#L155 (we will debate outright disabling this behavior or adding a setting toggle for it)

This image is sourced from the wiki, and they use much larger images for NPCs relative to item images (which we use for collection log and pet notification thumbnails)

@harbingerofme
Copy link
Author

Is there an icon in the top right of the first notif? I assume it's discord falling back because the first embed we intend to send is not being sent, and it's falling back to the second one, coming from the wiki link to Kraken.

Yes, that one is normal.

Maybe you can also try changing %BOSS% in your notification message to <%BOSS%>? That would work in theory since <link_here> is how you send a link on discord without embed.

For the record, the message previously was %COUNT% **%BOSS%**!. Adding brackets completely breaks it.
Screenshot 2024-10-28 221713

@harbingerofme
Copy link
Author

Full relevant config

image

@Felanbird
Copy link
Member

For the record, the message previously was %COUNT% **%BOSS%**!. Adding brackets completely breaks it.

heh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants