Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Fix crash when Mist would block a stat drop #4746

Merged
merged 4 commits into from
Oct 28, 2024
Merged

[Hotfix] Fix crash when Mist would block a stat drop #4746

merged 4 commits into from
Oct 28, 2024

Conversation

innerthunder
Copy link
Collaborator

What are the changes the user will see?

Stat-stage-decreasing effects should no longer crash the game when applying to a target while Mist is active

Why am I making these changes?

Oversight on my end...

What are the changes from a developer perspective?

phases/stat-stage-change-phase: Fixed incorrect arguments in the applyTagsForSide call for Mist (there was an extra false that was misplaced)

Screenshots/Videos

How to test the changes?

npm run test mist (1 new test + 1 new TODO for when Infiltrator is fully implemented)

Checklist

  • [n/a] I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [n/a] Are the changes visual?
    • [n/a] Have I provided screenshots/videos of the changes?

@innerthunder innerthunder requested a review from a team as a code owner October 28, 2024 02:17
@innerthunder innerthunder linked an issue Oct 28, 2024 that may be closed by this pull request
[Bug] Game freezes after attack lowering stats (e.g Bulldoze) when Mist has been used before #4737
Open
@innerthunder innerthunder added P1 Bug Major. Game crashing move/ability/interaction Move Affects a move labels Oct 28, 2024
@MokaStitcher MokaStitcher merged commit b4cc9d7 into pagefaultgames:main Oct 28, 2024
13 of 14 checks passed
MokaStitcher added a commit that referenced this pull request Oct 28, 2024
@MokaStitcher @f-fsantos
@innerthunder @PigeonBar @chaosgrimmon @pom-eranian
Main -> Beta (1.1.6) (#4751)
cab74f7 
* Comment out startGame call on manifest fetch failure

* [Hotfix] Fix status damage triggering before berry usage (#4732)

* [Hotfix] Fix Eternatus egg tier (#4734)

* [Hotfix] Fix manifest getting loaded before the game is initialized (#4739)

* fix locales path for offline builds (#4739)

* [Sprite] Hotfix cut off Binacle sprite (#4741)

* [Sprite][hotfix] Fixed cropping on 658 static greninja and ash greninja (#4743)

* [Sprite][hotfix] Fixed cropping on static greninja and ash greninja

* [Hotfix] Fix crash when Mist would block a stat drop (#4746)

---------

Co-authored-by: Frederico Santos <[email protected]>
Co-authored-by: innerthunder <[email protected]>
Co-authored-by: PigeonBar <[email protected]>
Co-authored-by: chaosgrimmon <[email protected]>
Co-authored-by: pom-eranian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torranx torranx torranx approved these changes

@MokaStitcher MokaStitcher Awaiting requested review from MokaStitcher MokaStitcher is a code owner automatically assigned from pagefaultgames/junior-dev-team

@Tempo-anon Tempo-anon Awaiting requested review from Tempo-anon Tempo-anon is a code owner automatically assigned from pagefaultgames/junior-dev-team

@pom-eranian pom-eranian Awaiting requested review from pom-eranian pom-eranian is a code owner automatically assigned from pagefaultgames/junior-dev-team

Assignees
No one assigned
Labels
Move Affects a move P1 Bug Major. Game crashing move/ability/interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Game freezes after attack lowering stats (e.g Bulldoze) when Mist has been used before
3 participants
@innerthunder @torranx @MokaStitcher