Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint failing against master branch #320

Closed
YOU54F opened this issue Jul 14, 2023 · 2 comments · Fixed by #323
Closed

golangci-lint failing against master branch #320

YOU54F opened this issue Jul 14, 2023 · 2 comments · Fixed by #323

Comments

@YOU54F
Copy link
Member

YOU54F commented Jul 14, 2023

golangci-lint is failing against the master branch

#310 will fix the build such that golangci-lint can run successfully.

This has highlighted linting errors in the master branch which now need resolving :)

This issue is to track. Contributions are welcome (Go isn't my strongest language!)

@YOU54F YOU54F changed the title golangci-lint golangci-lint failing against master branch Jul 14, 2023
boreyuk added a commit to boreyuk/pact-go that referenced this issue Jul 19, 2023
@boreyuk
Copy link
Contributor

boreyuk commented Jul 19, 2023

Hi ! I took a look at the errors raised by golangci-lint. Most of the errors is due to not checking error values returned by functions. For the moment, I explicitely ignored most of the errors returned, in order to not change the current behavior. However, I think that some errors should be managed. I put a "TODO" comment on these errors in my PR.

Feel free to review and give feedback :-)

@YOU54F YOU54F linked a pull request Aug 4, 2023 that will close this issue
@YOU54F
Copy link
Member Author

YOU54F commented Aug 4, 2023

Resolved thanks to @boreyuk!

Viva la community

@YOU54F YOU54F closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants