Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict mypy #251

Closed
lachmanfrantisek opened this issue Oct 22, 2019 · 15 comments
Closed

Strict mypy #251

lachmanfrantisek opened this issue Oct 22, 2019 · 15 comments
Labels
good-first-issue Good for newcomers. Hacktoberfest Participate in https://hacktoberfest.digitalocean.com kind/technical-debt The code needs love. Refactoring.

Comments

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Oct 22, 2019 •
edited
Loading

There are many warnings and errors when running mypy in a strict mode. Each error can mean potentially problematic part of the code. (The goal is to make the code better, not only to silence the mypy.)

It would be nice to reduce the number of errors/warnings.

What you can do:

  • Run the mypy on the code: 
    mypy ogr --strict
  • pick an error/warning
  • try to fix the problem which can mean
    • adding a type annotation
    • changing the type annotation
    • adding some test for the input and raising a propper exception
    • something else
  • send a PR with the fix or raise an issue if you found some problem, that cannot be easily fixed

This does not need to be done in one PR. Also, one fixed error can be useful to us.

'mypy ogr --strict' output 
$ mypy ogr --strict
ogr/deprecation.py:23: error: Cannot find implementation or library stub for module named 'deprecated'
ogr/deprecation.py:26: error: Function is missing a type annotation
ogr/services/github/auth_providers/abstract.py:6: error: Cannot find implementation or library stub for module named 'github'
ogr/services/github/auth_providers/abstract.py:6: note: See https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports
ogr/services/github/auth_providers/abstract.py:32: error: Function is missing a type annotation for one or more arguments
ogr/parsing.py:99: error: Function is missing a return type annotation
ogr/parsing.py:155: error: Argument 1 to "RepoUrl" has incompatible type "None"; expected "str"
ogr/services/github/auth_providers/token.py:6: error: Cannot find implementation or library stub for module named 'github'
ogr/services/github/auth_providers/token.py:12: error: Function is missing a type annotation for one or more arguments
ogr/services/github/auth_providers/token.py:35: error: Function is missing a type annotation for one or more arguments
ogr/services/github/auth_providers/token.py:35: error: Incompatible default for argument "token" (default has type "None", argument has type "str")
ogr/services/github/auth_providers/github_app.py:7: error: Cannot find implementation or library stub for module named 'github'
ogr/services/github/auth_providers/github_app.py:26: error: Returning Any from function declared to return "bool"
ogr/services/github/auth_providers/github_app.py:61: error: Incompatible return value type (got "None", expected "str")
ogr/services/github/auth_providers/github_app.py:76: error: Incompatible return value type (got "None", expected "str")
ogr/services/github/auth_providers/github_app.py:87: error: unused 'type: ignore' comment
ogr/services/github/auth_providers/github_app.py:94: error: unused 'type: ignore' comment
ogr/services/github/auth_providers/github_app.py:95: error: Returning Any from function declared to return "str"
ogr/services/github/auth_providers/github_app.py:98: error: Function is missing a type annotation for one or more arguments
ogr/services/github/auth_providers/github_app.py:99: error: Incompatible default for argument "github_app_id" (default has type "None", argument has type "str")
ogr/services/github/auth_providers/github_app.py:100: error: Incompatible default for argument "github_app_private_key" (default has type "None", argument has type "str")
ogr/services/github/auth_providers/github_app.py:101: error: Incompatible default for argument "github_app_private_key_path" (default has type "None", argument has type "str")
ogr/abstract.py:34: error: Module 'functools' has no attribute 'cached_property'
ogr/abstract.py:82: error: Function is missing a return type annotation
ogr/abstract.py:103: error: Incompatible return value type (got "Optional[datetime]", expected "datetime")
ogr/abstract.py:107: error: Incompatible return value type (got "Optional[datetime]", expected "datetime")
ogr/abstract.py:113: error: Incompatible return value type (got "Optional[Any]", expected "Issue")
ogr/abstract.py:122: error: Incompatible return value type (got "Optional[Any]", expected "PullRequest")
ogr/abstract.py:172: error: Missing type parameters for generic type "List"
ogr/abstract.py:244: error: Incompatible default for argument "filter_regex" (default has type "None", argument has type "str")
ogr/abstract.py:244: error: Incompatible default for argument "author" (default has type "None", argument has type "str")
ogr/abstract.py:299: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/abstract.py:299: error: Untyped decorator makes function "__init__" untyped
ogr/abstract.py:420: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/abstract.py:751: error: Untyped decorator makes function "hostname" untyped
ogr/abstract.py:1204: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/abstract.py:1224: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/abstract.py:1373: error: Incompatible default for argument "filter_regex" (default has type "None", argument has type "str")
ogr/read_only.py:52: error: Missing type parameters for generic type "Callable"
ogr/read_only.py:66: error: Function is missing a type annotation
ogr/read_only.py:68: error: Function is missing a type annotation
ogr/read_only.py:165: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/read_only.py:165: error: Untyped decorator makes function "pr_create" untyped
ogr/read_only.py:177: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/read_only.py:195: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/read_only.py:215: error: Incompatible default for argument "commit" (default has type "None", argument has type "str")
ogr/read_only.py:216: error: Incompatible default for argument "filename" (default has type "None", argument has type "str")
ogr/read_only.py:217: error: Incompatible default for argument "row" (default has type "None", argument has type "int")
ogr/read_only.py:233: error: Returning Any from function declared to return "PullRequest"
ogr/read_only.py:239: error: Returning Any from function declared to return "PullRequest"
ogr/read_only.py:257: error: Returning Any from function declared to return "GitProject"
ogr/factory.py:33: error: Function is missing a return type annotation
ogr/factory.py:33: error: Function is missing a type annotation for one or more arguments
ogr/factory.py:57: error: Function is missing a type annotation
ogr/factory.py:59: error: Function is missing a return type annotation
ogr/factory.py:65: error: Call to untyped function "decorator_cover" in typed context
ogr/factory.py:68: error: Function is missing a type annotation for one or more arguments
ogr/factory.py:70: error: Incompatible default for argument "service_mapping_update" (default has type "None", argument has type "Dict[str, Type[GitService]]")
ogr/factory.py:71: error: Incompatible default for argument "custom_instances" (default has type "None", argument has type "Iterable[GitService]")
ogr/factory.py:86: error: Invalid index type "Optional[str]" for "Dict[str, Type[GitService]]"; expected type "str"
ogr/factory.py:95: error: Item "None" of "Optional[RepoUrl]" has no attribute "hostname"
ogr/factory.py:105: error: Item "None" of "Optional[RepoUrl]" has no attribute "get_instance_url"
ogr/factory.py:110: error: Incompatible default for argument "service_mapping_update" (default has type "None", argument has type "Dict[str, Type[GitService]]")
ogr/factory.py:132: error: Incompatible default for argument "service_mapping_update" (default has type "None", argument has type "Dict[str, Type[GitService]]")
ogr/factory.py:149: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/gitlab/comments.py:26: error: Cannot find implementation or library stub for module named 'gitlab.v4.objects'
ogr/services/gitlab/comments.py:41: error: Returning Any from function declared to return "str"
ogr/services/gitlab/comments.py:50: error: Returning Any from function declared to return "datetime"
ogr/services/github/comments.py:26: error: Cannot find implementation or library stub for module named 'github.IssueComment'
ogr/services/github/comments.py:27: error: Cannot find implementation or library stub for module named 'github.PullRequestComment'
ogr/services/github/comments.py:42: error: Returning Any from function declared to return "str"
ogr/services/github/comments.py:50: error: Returning Any from function declared to return "datetime"
ogr/services/github/auth_providers/tokman.py:7: error: Cannot find implementation or library stub for module named 'github'
ogr/services/github/auth_providers/tokman.py:39: error: Returning Any from function declared to return "str"
ogr/services/github/auth_providers/tokman.py:42: error: Function is missing a type annotation for one or more arguments
ogr/services/github/auth_providers/tokman.py:42: error: Incompatible default for argument "tokman_instance_url" (default has type "None", argument has type "str")
ogr/services/base.py:46: error: Module 'functools' has no attribute 'cached_property'
ogr/services/base.py:55: error: Untyped decorator makes function "hostname" untyped
ogr/services/base.py:60: error: Argument "potential_url" to "parse_git_repo" has incompatible type "Optional[str]"; expected "str"
ogr/services/base.py:81: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:81: error: Untyped decorator makes function "get_pr_comments" untyped
ogr/services/base.py:86: error: Function is missing a type annotation for one or more arguments
ogr/services/base.py:87: error: Incompatible default for argument "filter_regex" (default has type "None", argument has type "str")
ogr/services/base.py:87: error: Incompatible default for argument "author" (default has type "None", argument has type "str")
ogr/services/base.py:100: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:100: error: Untyped decorator makes function "search_in_pr" untyped
ogr/services/base.py:123: error: Untyped decorator makes function "pr_close" untyped
ogr/services/base.py:124: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:124: error: Untyped decorator makes function "pr_close" untyped
ogr/services/base.py:132: error: Untyped decorator makes function "pr_merge" untyped
ogr/services/base.py:133: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:133: error: Untyped decorator makes function "pr_merge" untyped
ogr/services/base.py:141: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:141: error: Untyped decorator makes function "get_pr_labels" untyped
ogr/services/base.py:149: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:149: error: Untyped decorator makes function "add_pr_labels" untyped
ogr/services/base.py:157: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:157: error: Untyped decorator makes function "get_pr_info" untyped
ogr/services/base.py:165: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:165: error: Untyped decorator makes function "update_pr_info" untyped
ogr/services/base.py:175: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:175: error: Untyped decorator makes function "get_all_pr_commits" untyped
ogr/services/base.py:183: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:183: error: Untyped decorator makes function "_get_all_pr_comments" untyped
ogr/services/base.py:191: error: Untyped decorator makes function "pr_comment" untyped
ogr/services/base.py:195: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:195: error: Untyped decorator makes function "pr_comment" untyped
ogr/services/base.py:204: error: Incompatible default for argument "commit" (default has type "None", argument has type "str")
ogr/services/base.py:205: error: Incompatible default for argument "filename" (default has type "None", argument has type "str")
ogr/services/base.py:206: error: Incompatible default for argument "row" (default has type "None", argument has type "int")
ogr/services/base.py:210: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:210: error: Untyped decorator makes function "get_issue_comments" untyped
ogr/services/base.py:215: error: Function is missing a type annotation for one or more arguments
ogr/services/base.py:218: error: Incompatible default for argument "filter_regex" (default has type "None", argument has type "str")
ogr/services/base.py:220: error: Incompatible default for argument "author" (default has type "None", argument has type "str")
ogr/services/base.py:224: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:224: error: Untyped decorator makes function "pr_create" untyped
ogr/services/base.py:235: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/services/base.py:245: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:245: error: Untyped decorator makes function "can_close_issue" untyped
ogr/services/base.py:253: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:253: error: Untyped decorator makes function "get_issue_info" untyped
ogr/services/base.py:261: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:261: error: Untyped decorator makes function "_get_all_issue_comments" untyped
ogr/services/base.py:269: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:269: error: Untyped decorator makes function "issue_comment" untyped
ogr/services/base.py:277: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:277: error: Untyped decorator makes function "issue_close" untyped
ogr/services/base.py:285: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:285: error: Untyped decorator makes function "get_issue_labels" untyped
ogr/services/base.py:293: error: Call to untyped function "deprecate_and_set_removal" in typed context
ogr/services/base.py:293: error: Untyped decorator makes function "add_issue_labels" untyped
ogr/services/base.py:367: error: Function is missing a return type annotation
ogr/services/base.py:367: error: Argument 1 of "get_comments" is incompatible with supertype "PullRequest"; supertype defines the argument type as "Optional[str]"
ogr/services/base.py:367: error: Argument 3 of "get_comments" is incompatible with supertype "PullRequest"; supertype defines the argument type as "Optional[str]"
ogr/services/base.py:368: error: Incompatible default for argument "filter_regex" (default has type "None", argument has type "str")
ogr/services/base.py:368: error: Incompatible default for argument "author" (default has type "None", argument has type "str")
ogr/services/base.py:373: error: Function is missing a return type annotation
ogr/services/base.py:397: error: Incompatible default for argument "filter_regex" (default has type "None", argument has type "str")
ogr/services/base.py:397: error: Incompatible default for argument "author" (default has type "None", argument has type "str")
ogr/services/pagure/release.py:28: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/release.py:37: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/release.py:42: error: Function is missing a return type annotation
ogr/services/pagure/release.py:46: error: Function is missing a return type annotation
ogr/services/pagure/pull_request.py:38: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/pull_request.py:39: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/pull_request.py:41: error: Function is missing a type annotation
ogr/services/pagure/pull_request.py:45: error: Function is missing a return type annotation
ogr/services/pagure/pull_request.py:45: note: Use "-> None" if function does not return a value
ogr/services/pagure/pull_request.py:52: error: Call to untyped function "__update" in typed context
ogr/services/pagure/pull_request.py:53: error: Returning Any from function declared to return "str"
ogr/services/pagure/pull_request.py:61: error: Returning Any from function declared to return "int"
ogr/services/pagure/pull_request.py:65: error: Call to untyped function "__update" in typed context
ogr/services/pagure/pull_request.py:72: error: List item 0 has incompatible type "Optional[str]"; expected "str"
ogr/services/pagure/pull_request.py:81: error: Call to untyped function "__update" in typed context
ogr/services/pagure/pull_request.py:82: error: Returning Any from function declared to return "str"
ogr/services/pagure/pull_request.py:90: error: Returning Any from function declared to return "str"
ogr/services/pagure/pull_request.py:94: error: Returning Any from function declared to return "str"
ogr/services/pagure/pull_request.py:98: error: Returning Any from function declared to return "str"
ogr/services/pagure/pull_request.py:117: error: Returning Any from function declared to return "bytes"
ogr/services/pagure/pull_request.py:121: error: Returning Any from function declared to return "str"
ogr/services/pagure/pull_request.py:124: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/pull_request.py:145: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/pull_request.py:145: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/pagure/pull_request.py:146: error: Returning Any from function declared to return "Dict[Any, Any]"
ogr/services/pagure/pull_request.py:152: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/pull_request.py:157: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/services/pagure/pull_request.py:178: error: Returning Any from function declared to return "PullRequest"
ogr/services/pagure/pull_request.py:178: error: Call to untyped function "PagurePullRequest" in typed context
ogr/services/pagure/pull_request.py:181: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/pull_request.py:183: error: Returning Any from function declared to return "PullRequest"
ogr/services/pagure/pull_request.py:183: error: Call to untyped function "PagurePullRequest" in typed context
ogr/services/pagure/pull_request.py:186: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/pull_request.py:187: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/pull_request.py:199: error: Call to untyped function "PagurePullRequest" in typed context
ogr/services/pagure/pull_request.py:219: error: Call to untyped function "__update" in typed context
ogr/services/pagure/pull_request.py:266: error: Call to untyped function "__update" in typed context
ogr/services/pagure/pull_request.py:277: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/pagure/issue.py:34: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/issue.py:36: error: Function is missing a type annotation
ogr/services/pagure/issue.py:40: error: Function is missing a return type annotation
ogr/services/pagure/issue.py:40: note: Use "-> None" if function does not return a value
ogr/services/pagure/issue.py:47: error: Call to untyped function "__update" in typed context
ogr/services/pagure/issue.py:48: error: Returning Any from function declared to return "str"
ogr/services/pagure/issue.py:56: error: Call to untyped function "__update" in typed context
ogr/services/pagure/issue.py:57: error: Returning Any from function declared to return "bool"
ogr/services/pagure/issue.py:61: error: Returning Any from function declared to return "int"
ogr/services/pagure/issue.py:65: error: Call to untyped function "__update" in typed context
ogr/services/pagure/issue.py:70: error: Returning Any from function declared to return "str"
ogr/services/pagure/issue.py:76: error: Call to untyped function "__update" in typed context
ogr/services/pagure/issue.py:77: error: Returning Any from function declared to return "str"
ogr/services/pagure/issue.py:85: error: Returning Any from function declared to return "str"
ogr/services/pagure/issue.py:93: error: Returning Any from function declared to return "List[str]"
ogr/services/pagure/issue.py:118: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/issue.py:132: error: Returning Any from function declared to return "Issue"
ogr/services/pagure/issue.py:132: error: Call to untyped function "PagureIssue" in typed context
ogr/services/pagure/issue.py:135: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/issue.py:137: error: Returning Any from function declared to return "Issue"
ogr/services/pagure/issue.py:137: error: Call to untyped function "PagureIssue" in typed context
ogr/services/pagure/issue.py:141: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/issue.py:168: error: Call to untyped function "PagureIssue" in typed context
ogr/services/pagure/issue.py:171: error: Call to untyped function "__update" in typed context
ogr/services/pagure/flag.py:44: error: Function is missing a return type annotation
ogr/services/pagure/flag.py:44: note: Use "-> None" if function does not return a value
ogr/services/pagure/flag.py:45: error: Value of type "Optional[Any]" is not indexable
ogr/services/pagure/flag.py:46: error: Value of type "Optional[Any]" is not indexable
ogr/services/pagure/flag.py:47: error: Value of type "Optional[Any]" is not indexable
ogr/services/pagure/flag.py:48: error: Value of type "Optional[Any]" is not indexable
ogr/services/pagure/flag.py:49: error: Value of type "Optional[Any]" is not indexable
ogr/services/pagure/flag.py:52: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/flag.py:61: error: Name 'ogr_pagure.PagureProject' is not defined
ogr/services/pagure/flag.py:67: error: Incompatible default for argument "percent" (default has type "None", argument has type "int")
ogr/services/pagure/flag.py:69: error: Incompatible default for argument "uid" (default has type "None", argument has type "str")
ogr/services/pagure/flag.py:97: error: Value of type "Optional[Any]" is not indexable
ogr/services/pagure/flag.py:103: error: Value of type "Optional[Any]" is not indexable
ogr/services/pagure/project.py:58: error: Name 'ogr_pagure.PagureService' is not defined
ogr/services/pagure/project.py:64: error: Name 'ogr_pagure.PagureService' is not defined
ogr/services/pagure/project.py:65: error: Incompatible default for argument "username" (default has type "None", argument has type "str")
ogr/services/pagure/project.py:68: error: Argument 3 to "__init__" of "GitProject" has incompatible type "Optional[str]"; expected "str"
ogr/services/pagure/project.py:75: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str")
ogr/services/pagure/project.py:102: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/project.py:107: error: Incompatible default for argument "method" (default has type "None", argument has type "str")
ogr/services/pagure/project.py:108: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/pagure/project.py:108: error: Incompatible default for argument "params" (default has type "None", argument has type "Dict[Any, Any]")
ogr/services/pagure/project.py:109: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/pagure/project.py:109: error: Incompatible default for argument "data" (default has type "None", argument has type "Dict[Any, Any]")
ogr/services/pagure/project.py:110: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/pagure/project.py:122: error: Call to untyped function "_get_project_url" in typed context
ogr/services/pagure/project.py:128: error: Returning Any from function declared to return "Dict[Any, Any]"
ogr/services/pagure/project.py:132: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/project.py:137: error: Incompatible default for argument "method" (default has type "None", argument has type "str")
ogr/services/pagure/project.py:138: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/pagure/project.py:138: error: Incompatible default for argument "params" (default has type "None", argument has type "Dict[Any, Any]")
ogr/services/pagure/project.py:139: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/pagure/project.py:139: error: Incompatible default for argument "data" (default has type "None", argument has type "Dict[Any, Any]")
ogr/services/pagure/project.py:152: error: Call to untyped function "_get_project_url" in typed context
ogr/services/pagure/project.py:158: error: Returning Any from function declared to return "RequestResponse"
ogr/services/pagure/project.py:162: error: Function is missing a type annotation
ogr/services/pagure/project.py:163: error: Need type annotation for 'additional_parts' (hint: "additional_parts: List[<type>] = ...")
ogr/services/pagure/project.py:174: error: Function is missing a return type annotation
ogr/services/pagure/project.py:179: error: Returning Any from function declared to return "List[str]"
ogr/services/pagure/project.py:182: error: Returning Any from function declared to return "str"
ogr/services/pagure/project.py:182: error: Call to untyped function "get_project_info" in typed context
ogr/services/pagure/project.py:185: error: Call to untyped function "get_project_info" in typed context
ogr/services/pagure/project.py:186: error: Returning Any from function declared to return "List[str]"
ogr/services/pagure/project.py:190: error: Call to untyped function "get_project_info" in typed context
ogr/services/pagure/project.py:199: error: Call to untyped function "get_project_info" in typed context
ogr/services/pagure/project.py:205: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/project.py:208: error: Function is missing a return type annotation
ogr/services/pagure/project.py:208: note: Use "-> None" if function does not return a value
ogr/services/pagure/project.py:236: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/project.py:246: error: Untyped decorator makes function "create_pr" untyped
ogr/services/pagure/project.py:253: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/services/pagure/project.py:263: error: Untyped decorator makes function "fork_create" untyped
ogr/services/pagure/project.py:295: error: Call to untyped function "get_project_info" in typed context
ogr/services/pagure/project.py:301: error: Returning Any from function declared to return "Optional[PagureProject]"
ogr/services/pagure/project.py:310: error: Function is missing a return type annotation
ogr/services/pagure/project.py:342: error: Call to untyped function "exists" in typed context
ogr/services/pagure/project.py:342: error: Item "None" of "Optional[PagureProject]" has no attribute "exists"
ogr/services/pagure/project.py:345: error: Call to untyped function "get_project_info" in typed context
ogr/services/pagure/project.py:359: error: Call to untyped function "get_project_info" in typed context
ogr/services/pagure/project.py:366: error: Returning Any from function declared to return "Dict[str, str]"
ogr/services/pagure/project.py:378: error: Function is missing a return type annotation
ogr/services/pagure/project.py:388: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/project.py:420: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/project.py:438: error: Argument 3 of "commit_comment" is incompatible with supertype "GitProject"; supertype defines the argument type as "Optional[str]"
ogr/services/pagure/project.py:438: error: Argument 4 of "commit_comment" is incompatible with supertype "GitProject"; supertype defines the argument type as "Optional[int]"
ogr/services/pagure/project.py:439: error: Incompatible default for argument "filename" (default has type "None", argument has type "str")
ogr/services/pagure/project.py:439: error: Incompatible default for argument "row" (default has type "None", argument has type "int")
ogr/services/pagure/project.py:443: error: Untyped decorator makes function "set_commit_status" untyped
ogr/services/pagure/project.py:451: error: Incompatible default for argument "percent" (default has type "None", argument has type "int")
ogr/services/pagure/project.py:452: error: Incompatible default for argument "uid" (default has type "None", argument has type "str")
ogr/services/pagure/project.py:520: error: Call to untyped function "get_project_info" in typed context
ogr/services/pagure/user.py:31: error: Name 'ogr_pagure.PagureService' is not defined
ogr/services/pagure/user.py:33: error: Name 'ogr_pagure.PagureService' is not defined
ogr/services/pagure/user.py:43: error: Returning Any from function declared to return "str"
ogr/services/pagure/service.py:44: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/service.py:46: error: Incompatible default for argument "token" (default has type "None", argument has type "str")
ogr/services/pagure/service.py:88: error: Returning Any from function declared to return "bool"
ogr/services/pagure/service.py:99: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/service.py:110: error: Item "None" of "Optional[RepoUrl]" has no attribute "repo"
ogr/services/pagure/service.py:111: error: Item "None" of "Optional[RepoUrl]" has no attribute "namespace"
ogr/services/pagure/service.py:112: error: Item "None" of "Optional[RepoUrl]" has no attribute "is_fork"
ogr/services/pagure/service.py:113: error: Item "None" of "Optional[RepoUrl]" has no attribute "username"
ogr/services/pagure/service.py:121: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/service.py:122: error: Incompatible default for argument "method" (default has type "None", argument has type "str")
ogr/services/pagure/service.py:122: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/pagure/service.py:122: error: Incompatible default for argument "params" (default has type "None", argument has type "Dict[Any, Any]")
ogr/services/pagure/service.py:123: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/pagure/service.py:160: error: Returning Any from function declared to return "Dict[Any, Any]"
ogr/services/pagure/service.py:162: error: Function is missing a return type annotation
ogr/services/pagure/service.py:162: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/service.py:163: error: Incompatible default for argument "method" (default has type "None", argument has type "str")
ogr/services/pagure/service.py:163: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/pagure/service.py:163: error: Incompatible default for argument "params" (default has type "None", argument has type "Dict[Any, Any]")
ogr/services/pagure/service.py:176: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/service.py:204: error: Function is missing a return type annotation
ogr/services/pagure/service.py:207: error: Function is missing a type annotation for one or more arguments
ogr/services/pagure/service.py:220: error: Returning Any from function declared to return "str"
ogr/services/pagure/service.py:230: error: Returning Any from function declared to return "str"
ogr/services/pagure/service.py:232: error: Function is missing a return type annotation
ogr/services/pagure/service.py:241: error: Function is missing a return type annotation
ogr/services/pagure/service.py:283: error: Argument 2 to "__handle_project_create_fail" of "PagureService" has incompatible type "Optional[str]"; expected "str"
ogr/services/gitlab/user.py:28: error: Name 'ogr_gitlab.GitlabService' is not defined
ogr/services/gitlab/user.py:30: error: Name 'ogr_gitlab.GitlabService' is not defined
ogr/services/gitlab/user.py:37: error: Function is missing a return type annotation
ogr/services/gitlab/user.py:41: error: Returning Any from function declared to return "str"
ogr/services/gitlab/user.py:44: error: Returning Any from function declared to return "str"
ogr/services/gitlab/release.py:30: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/release.py:32: error: Function is missing a type annotation for one or more arguments
ogr/services/gitlab/release.py:39: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/release.py:46: error: Function is missing a return type annotation
ogr/services/gitlab/release.py:50: error: Function is missing a return type annotation
ogr/services/gitlab/pull_request.py:26: error: Cannot find implementation or library stub for module named 'gitlab.v4.objects'
ogr/services/gitlab/pull_request.py:37: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/pull_request.py:38: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/pull_request.py:42: error: Returning Any from function declared to return "str"
ogr/services/gitlab/pull_request.py:51: error: Returning Any from function declared to return "int"
ogr/services/gitlab/pull_request.py:63: error: Returning Any from function declared to return "str"
ogr/services/gitlab/pull_request.py:67: error: Returning Any from function declared to return "str"
ogr/services/gitlab/pull_request.py:76: error: Returning Any from function declared to return "str"
ogr/services/gitlab/pull_request.py:80: error: Returning Any from function declared to return "str"
ogr/services/gitlab/pull_request.py:84: error: Returning Any from function declared to return "str"
ogr/services/gitlab/pull_request.py:88: error: Returning Any from function declared to return "datetime"
ogr/services/gitlab/pull_request.py:92: error: Returning Any from function declared to return "List[str]"
ogr/services/gitlab/pull_request.py:100: error: Returning Any from function declared to return "str"
ogr/services/gitlab/pull_request.py:103: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/pull_request.py:117: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/pull_request.py:122: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/services/gitlab/pull_request.py:169: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/pull_request.py:170: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/pull_request.py:190: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/pull_request.py:196: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/issue.py:26: error: Cannot find implementation or library stub for module named 'gitlab'
ogr/services/gitlab/issue.py:27: error: Cannot find implementation or library stub for module named 'gitlab.v4.objects'
ogr/services/gitlab/issue.py:41: error: Returning Any from function declared to return "str"
ogr/services/gitlab/issue.py:50: error: Returning Any from function declared to return "int"
ogr/services/gitlab/issue.py:54: error: Returning Any from function declared to return "bool"
ogr/services/gitlab/issue.py:66: error: Returning Any from function declared to return "str"
ogr/services/gitlab/issue.py:70: error: Returning Any from function declared to return "str"
ogr/services/gitlab/issue.py:79: error: Returning Any from function declared to return "str"
ogr/services/gitlab/issue.py:83: error: Returning Any from function declared to return "datetime"
ogr/services/gitlab/issue.py:86: error: Missing type parameters for generic type "List"
ogr/services/gitlab/issue.py:87: error: Returning Any from function declared to return "List[Any]"
ogr/services/gitlab/issue.py:94: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/issue.py:107: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/issue.py:115: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/flag.py:27: error: Cannot find implementation or library stub for module named 'gitlab'
ogr/services/gitlab/flag.py:53: error: Function is missing a return type annotation
ogr/services/gitlab/flag.py:53: note: Use "-> None" if function does not return a value
ogr/services/gitlab/flag.py:54: error: Item "None" of "Optional[Any]" has no attribute "sha"
ogr/services/gitlab/flag.py:55: error: Item "None" of "Optional[Any]" has no attribute "status"
ogr/services/gitlab/flag.py:56: error: Item "None" of "Optional[Any]" has no attribute "name"
ogr/services/gitlab/flag.py:57: error: Item "None" of "Optional[Any]" has no attribute "description"
ogr/services/gitlab/flag.py:58: error: Item "None" of "Optional[Any]" has no attribute "id"
ogr/services/gitlab/flag.py:59: error: Item "None" of "Optional[Any]" has no attribute "target_url"
ogr/services/gitlab/flag.py:62: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/flag.py:77: error: Name 'ogr_gitlab.GitlabProject' is not defined
ogr/services/gitlab/flag.py:108: error: Item "None" of "Optional[Any]" has no attribute "created_at"
ogr/services/gitlab/project.py:26: error: Cannot find implementation or library stub for module named 'gitlab'
ogr/services/gitlab/project.py:27: error: Cannot find implementation or library stub for module named 'gitlab.v4.objects'
ogr/services/gitlab/project.py:54: error: Name 'ogr_gitlab.GitlabService' is not defined
ogr/services/gitlab/project.py:56: error: Function is missing a type annotation for one or more arguments
ogr/services/gitlab/project.py:59: error: Name 'ogr_gitlab.GitlabService' is not defined
ogr/services/gitlab/project.py:129: error: Returning Any from function declared to return "bool"
ogr/services/gitlab/project.py:135: error: Returning Any from function declared to return "str"
ogr/services/gitlab/project.py:190: error: Function is missing a type annotation for one or more arguments
ogr/services/gitlab/project.py:256: error: Returning Any from function declared to return "str"
ogr/services/gitlab/project.py:267: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/services/gitlab/project.py:278: error: Argument 3 of "commit_comment" is incompatible with supertype "GitProject"; supertype defines the argument type as "Optional[str]"
ogr/services/gitlab/project.py:278: error: Argument 4 of "commit_comment" is incompatible with supertype "GitProject"; supertype defines the argument type as "Optional[int]"
ogr/services/gitlab/project.py:279: error: Incompatible default for argument "filename" (default has type "None", argument has type "str")
ogr/services/gitlab/project.py:279: error: Incompatible default for argument "row" (default has type "None", argument has type "int")
ogr/services/gitlab/project.py:364: error: Function is missing a return type annotation
ogr/services/gitlab/project.py:370: error: Function is missing a type annotation for one or more arguments
ogr/services/gitlab/project.py:373: error: Returning Any from function declared to return "str"
ogr/services/gitlab/project.py:378: error: Incompatible default for argument "filter_regex" (default has type "None", argument has type "str")
ogr/services/gitlab/project.py:449: error: Function is missing a type annotation for one or more arguments
ogr/services/gitlab/project.py:455: error: Function is missing a type annotation for one or more arguments
ogr/services/gitlab/project.py:473: error: Function is missing a return type annotation
ogr/services/gitlab/project.py:505: error: Function is missing a type annotation
ogr/services/gitlab/project.py:517: error: Call to untyped function "_normalize_label_color" in typed context
ogr/services/gitlab/project.py:530: error: Function is missing a type annotation
ogr/services/gitlab/project.py:536: error: Function is missing a type annotation for one or more arguments
ogr/services/gitlab/project.py:541: error: Function is missing a type annotation for one or more arguments
ogr/services/gitlab/project.py:560: error: Returning Any from function declared to return "str"
ogr/services/gitlab/service.py:23: error: Cannot find implementation or library stub for module named 'gitlab'
ogr/services/gitlab/service.py:37: error: Function is missing a type annotation
ogr/services/gitlab/service.py:75: error: Returning Any from function declared to return "bool"
ogr/services/gitlab/service.py:84: error: Function is missing a type annotation for one or more arguments
ogr/services/gitlab/service.py:104: error: Argument 2 of "project_create" is incompatible with supertype "GitService"; supertype defines the argument type as "Optional[str]"
ogr/services/gitlab/service.py:104: error: Incompatible default for argument "namespace" (default has type "None", argument has type "str")
ogr/services/github/release.py:23: error: Cannot find implementation or library stub for module named 'github.GitRelease'
ogr/services/github/release.py:30: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/release.py:39: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/release.py:46: error: Function is missing a return type annotation
ogr/services/github/release.py:50: error: Function is missing a return type annotation
ogr/services/github/pull_request.py:27: error: Cannot find implementation or library stub for module named 'github'
ogr/services/github/pull_request.py:28: error: Cannot find implementation or library stub for module named 'github.Label'
ogr/services/github/pull_request.py:29: error: Cannot find implementation or library stub for module named 'github.PullRequest'
ogr/services/github/pull_request.py:30: error: Cannot find implementation or library stub for module named 'github.Repository'
ogr/services/github/pull_request.py:31: error: Cannot find implementation or library stub for module named 'github.IssueComment'
ogr/services/github/pull_request.py:32: error: Cannot find implementation or library stub for module named 'github.PullRequestComment'
ogr/services/github/pull_request.py:45: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/pull_request.py:46: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/pull_request.py:50: error: Returning Any from function declared to return "str"
ogr/services/github/pull_request.py:58: error: Returning Any from function declared to return "int"
ogr/services/github/pull_request.py:70: error: Returning Any from function declared to return "str"
ogr/services/github/pull_request.py:74: error: Returning Any from function declared to return "str"
ogr/services/github/pull_request.py:82: error: Returning Any from function declared to return "str"
ogr/services/github/pull_request.py:86: error: Returning Any from function declared to return "str"
ogr/services/github/pull_request.py:90: error: Returning Any from function declared to return "str"
ogr/services/github/pull_request.py:94: error: Returning Any from function declared to return "datetime"
ogr/services/github/pull_request.py:106: error: Returning Any from function declared to return "str"
ogr/services/github/pull_request.py:109: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/pull_request.py:124: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/pull_request.py:129: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/services/github/pull_request.py:166: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/pull_request.py:172: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/issue.py:26: error: Cannot find implementation or library stub for module named 'github'
ogr/services/github/issue.py:27: error: Cannot find implementation or library stub for module named 'github.Issue'
ogr/services/github/issue.py:40: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/issue.py:51: error: Returning Any from function declared to return "str"
ogr/services/github/issue.py:59: error: Returning Any from function declared to return "int"
ogr/services/github/issue.py:67: error: Returning Any from function declared to return "str"
ogr/services/github/issue.py:71: error: Returning Any from function declared to return "str"
ogr/services/github/issue.py:79: error: Returning Any from function declared to return "str"
ogr/services/github/issue.py:83: error: Returning Any from function declared to return "datetime"
ogr/services/github/issue.py:86: error: Missing type parameters for generic type "List"
ogr/services/github/issue.py:94: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/issue.py:106: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/issue.py:112: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/flag.py:26: error: Cannot find implementation or library stub for module named 'github'
ogr/services/github/flag.py:44: error: Function is missing a return type annotation
ogr/services/github/flag.py:44: note: Use "-> None" if function does not return a value
ogr/services/github/flag.py:45: error: Item "None" of "Optional[Any]" has no attribute "state"
ogr/services/github/flag.py:46: error: Item "None" of "Optional[Any]" has no attribute "context"
ogr/services/github/flag.py:47: error: Item "None" of "Optional[Any]" has no attribute "description"
ogr/services/github/flag.py:48: error: Item "None" of "Optional[Any]" has no attribute "target_url"
ogr/services/github/flag.py:49: error: Item "None" of "Optional[Any]" has no attribute "id"
ogr/services/github/flag.py:52: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/flag.py:67: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/flag.py:87: error: Returning Any from function declared to return "datetime"
ogr/services/github/flag.py:87: error: Item "None" of "Optional[Any]" has no attribute "created_at"
ogr/services/github/flag.py:91: error: Returning Any from function declared to return "datetime"
ogr/services/github/flag.py:91: error: Item "None" of "Optional[Any]" has no attribute "updated_at"
ogr/services/github/project.py:26: error: Cannot find implementation or library stub for module named 'github'
ogr/services/github/project.py:28: error: Cannot find implementation or library stub for module named 'github.Repository'
ogr/services/github/project.py:29: error: Cannot find implementation or library stub for module named 'github.CommitComment'
ogr/services/github/project.py:30: error: Cannot find implementation or library stub for module named 'github.GitRelease'
ogr/services/github/project.py:58: error: Name 'ogr_github.GithubService' is not defined
ogr/services/github/project.py:62: error: Function is missing a type annotation for one or more arguments
ogr/services/github/project.py:65: error: Name 'ogr_github.GithubService' is not defined
ogr/services/github/project.py:82: error: Function is missing a return type annotation
ogr/services/github/project.py:91: error: Function is missing a return type annotation
ogr/services/github/project.py:133: error: Returning Any from function declared to return "bool"
ogr/services/github/project.py:150: error: Returning Any from function declared to return "bool"
ogr/services/github/project.py:167: error: Returning Any from function declared to return "str"
ogr/services/github/project.py:194: error: Function is missing a return type annotation
ogr/services/github/project.py:194: note: Use "-> None" if function does not return a value
ogr/services/github/project.py:213: error: Returning Any from function declared to return "Optional[GithubProject]"
ogr/services/github/project.py:248: error: Function is missing a type annotation for one or more arguments
ogr/services/github/project.py:254: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
ogr/services/github/project.py:302: error: Returning Any from function declared to return "str"
ogr/services/github/project.py:312: error: Untyped decorator makes function "create_pr" untyped
ogr/services/github/project.py:319: error: Incompatible default for argument "fork_username" (default has type "None", argument has type "str")
ogr/services/github/project.py:330: error: Untyped decorator makes function "commit_comment" untyped
ogr/services/github/project.py:335: error: Incompatible default for argument "filename" (default has type "None", argument has type "str")
ogr/services/github/project.py:335: error: Incompatible default for argument "row" (default has type "None", argument has type "int")
ogr/services/github/project.py:355: error: Untyped decorator makes function "set_commit_status" untyped
ogr/services/github/project.py:359: error: Function is missing a return type annotation
ogr/services/github/project.py:402: error: Untyped decorator makes function "fork_create" untyped
ogr/services/github/project.py:411: error: Returning Any from function declared to return "GithubProject"
ogr/services/github/project.py:415: error: Function is missing a return type annotation
ogr/services/github/project.py:418: error: Function is missing a type annotation for one or more arguments
ogr/services/github/project.py:420: error: Returning Any from function declared to return "str"
ogr/services/github/project.py:427: error: Incompatible default for argument "filter_regex" (default has type "None", argument has type "str")
ogr/services/github/project.py:498: error: Function is missing a return type annotation
ogr/services/github/project.py:505: error: Function is missing a type annotation
ogr/services/github/project.py:516: error: Call to untyped function "_normalize_label_color" in typed context
ogr/services/github/project.py:525: error: Function is missing a type annotation
ogr/services/github/project.py:530: error: Function is missing a type annotation for one or more arguments
ogr/services/github/project.py:534: error: Returning Any from function declared to return "Optional[int]"
ogr/services/github/project.py:537: error: Function is missing a type annotation for one or more arguments
ogr/services/github/project.py:541: error: Returning Any from function declared to return "Optional[int]"
ogr/services/github/project.py:544: error: Function is missing a type annotation for one or more arguments
ogr/services/github/project.py:553: error: Argument "git_tag" to "_release_from_github_object" of "GithubProject" has incompatible type "Optional[GitTag]"; expected "GitTag"
ogr/services/github/project.py:559: error: Argument "git_tag" to "_release_from_github_object" of "GithubProject" has incompatible type "Optional[GitTag]"; expected "GitTag"
ogr/services/github/project.py:567: error: Argument "git_tag" to "_release_from_github_object" of "GithubProject" has incompatible type "Optional[GitTag]"; expected "GitTag"
ogr/services/github/project.py:596: error: Returning Any from function declared to return "str"
ogr/services/github/user.py:31: error: Name 'ogr_github.GithubService' is not defined
ogr/services/github/user.py:33: error: Name 'ogr_github.GithubService' is not defined
ogr/services/github/user.py:40: error: Function is missing a return type annotation
ogr/services/github/user.py:44: error: Returning Any from function declared to return "str"
ogr/services/github/user.py:46: error: Return type "Optional[str]" of "get_email" incompatible with return type "str" in supertype "GitUser"
ogr/services/github/user.py:49: error: Returning Any from function declared to return "Optional[str]"
ogr/services/github/user.py:58: error: Returning Any from function declared to return "Optional[str]"
ogr/services/github/user.py:61: error: Returning Any from function declared to return "Optional[str]"
ogr/services/github/user.py:63: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/user.py:75: error: Name 'ogr_github.GithubProject' is not defined
ogr/services/github/service.py:25: error: Cannot find implementation or library stub for module named 'github'
ogr/services/github/service.py:37: error: Module 'ogr.services.github.auth_providers' has no attribute 'GithubAuthentication'
ogr/services/github/service.py:37: error: Module 'ogr.services.github.auth_providers' has no attribute 'TokenAuthentication'
ogr/services/github/service.py:37: error: Module 'ogr.services.github.auth_providers' has no attribute 'GithubApp'
ogr/services/github/service.py:37: error: Module 'ogr.services.github.auth_providers' has no attribute 'Tokman'
ogr/services/github/service.py:52: error: Function is missing a type annotation for one or more arguments
ogr/services/github/service.py:56: error: Incompatible default for argument "github_app_id" (default has type "None", argument has type "str")
ogr/services/github/service.py:57: error: Incompatible default for argument "github_app_private_key" (default has type "None", argument has type "str")
ogr/services/github/service.py:58: error: Incompatible default for argument "github_app_private_key_path" (default has type "None", argument has type "str")
ogr/services/github/service.py:59: error: Incompatible default for argument "tokman_instance_url" (default has type "None", argument has type "str")
ogr/services/github/service.py:74: error: Call to untyped function "__set_authentication" in typed context
ogr/services/github/service.py:82: error: Function is missing a type annotation
ogr/services/github/service.py:96: error: Function is missing a return type annotation
ogr/services/github/service.py:113: error: Returning Any from function declared to return "bool"
ogr/services/github/service.py:121: error: Function is missing a type annotation for one or more arguments
ogr/services/github/service.py:152: error: Argument 2 of "project_create" is incompatible with supertype "GitService"; supertype defines the argument type as "Optional[str]"
ogr/services/github/service.py:152: error: Incompatible default for argument "namespace" (default has type "None", argument has type "str")
ogr/__init__.py:35: error: Module 'ogr.services.github' has no attribute 'GithubService'
ogr/__init__.py:36: error: Module 'ogr.services.gitlab' has no attribute 'GitlabService'
ogr/__init__.py:37: error: Module 'ogr.services.pagure' has no attribute 'PagureService'
Found 512 errors in 34 files (checked 43 source files)
@lachmanfrantisek lachmanfrantisek added good-first-issue Good for newcomers. kind/technical-debt The code needs love. Refactoring. Hacktoberfest Participate in https://hacktoberfest.digitalocean.com labels Oct 22, 2019
@maniis

This comment has been minimized.

Sign in to view
@pywkm

This comment has been minimized.

Sign in to view
@pywkm

This comment has been minimized.

Sign in to view
@maniis

This comment has been minimized.

Sign in to view
@lachmanfrantisek

This comment has been minimized.

Sign in to view
@pywkm

This comment has been minimized.

Sign in to view
@lachmanfrantisek

This comment has been minimized.

Sign in to view
@pywkm

This comment has been minimized.

Sign in to view
@pywkm

This comment has been minimized.

Sign in to view
@lachmanfrantisek

This comment has been minimized.

Sign in to view
@lachmanfrantisek

This comment has been minimized.

Sign in to view
@lachmanfrantisek

This comment has been minimized.

Sign in to view
This was referenced Oct 26, 2019
Merged
Merged
Merged
Merged
@lachmanfrantisek lachmanfrantisek removed the Hacktoberfest Participate in https://hacktoberfest.digitalocean.com label Nov 4, 2019
@stale

This comment has been minimized.

Sign in to view
@stale stale bot added the stale Is the issue still valid? label Jan 3, 2020
@lachmanfrantisek lachmanfrantisek added the complexity/epic Lost of work ahead, planning/design required. label Jan 3, 2020
@stale stale bot removed the stale Is the issue still valid? label Jan 3, 2020
@lachmanfrantisek

This comment has been minimized.

Sign in to view
@lachmanfrantisek lachmanfrantisek added the Hacktoberfest Participate in https://hacktoberfest.digitalocean.com label Sep 30, 2020
shepherdjay added a commit to shepherdjay/ogr that referenced this issue Oct 9, 2021
@shepherdjay
Add return types
5b545ad 
mypy error cleanup packit#251
@shepherdjay shepherdjay mentioned this issue Oct 9, 2021
Closed
@jpopelka jpopelka mentioned this issue Jul 11, 2022
Open
@FrNecas FrNecas mentioned this issue Jul 14, 2022
Open
1 task
@lachmanfrantisek lachmanfrantisek moved this to 📋 Backlog 🔟 in Packit Kanban Board Sep 6, 2022
@lachmanfrantisek lachmanfrantisek removed the complexity/epic Lost of work ahead, planning/design required. label Oct 12, 2022
@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Dec 7, 2022 •
edited
Loading

I am going to close this. This is really hard to resolve at once and it does not have much sense to leave the issue open. Also, @FrNecas has an open PR (#723) to resolve key parts.

But the fixes are still more than welcome!

Repository owner moved this from backlog to done in Packit Kanban Board Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers. Hacktoberfest Participate in https://hacktoberfest.digitalocean.com kind/technical-debt The code needs love. Refactoring.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pywkm @lachmanfrantisek @maniis