Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faccessors need custorm equal_to_tol operation #1795

Open
abuts opened this issue Dec 20, 2024 · 0 comments
Open

faccessors need custorm equal_to_tol operation #1795

abuts opened this issue Dec 20, 2024 · 0 comments
Labels
bug Something isn't working Technical Debt code quality, unit tests, code duplicaton

Comments

@abuts
Copy link
Member

abuts commented Dec 20, 2024

This ticket is part of Re #1147 wich sorted main issues with equal_to_tol but left small independant things unfinished.

equal_to_tol operation is now defined on serializable and uses saveableFields to define what to compare.

faccessors have overloaded loadobj and saveobj which requere protected fields to be set, saved and loaded.
As saveableFields now returns protected properties, standard equal_to_tol can not access them so fails on objects comparison

faccessors need custom equal_to_tol operation.

@abuts abuts added bug Something isn't working Technical Debt code quality, unit tests, code duplicaton labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Technical Debt code quality, unit tests, code duplicaton
Projects
None yet
Development

No branches or pull requests

1 participant