Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashes to file storage of unique objects container #1784

Open
cmarooney-stfc opened this issue Dec 12, 2024 · 0 comments · May be fixed by #1785
Open

Add hashes to file storage of unique objects container #1784

cmarooney-stfc opened this issue Dec 12, 2024 · 0 comments · May be fixed by #1785

Comments

@cmarooney-stfc
Copy link
Collaborator

In the original version of unique_objects_container, the hashes used to indicate uniqueness were written to file on saving and restored on loading. When it was found that this did not always yield the same hashes on different platforms, the hashes were instead regenerated on load.

The hashing algorithm has now changed and uses GetMD5 defined in the Horace code base. This means that the hashing should be independent of the platform used.

It is found that hashing can add significantly to load times, and when multiple small cuts are generated this slows down the use of Horace. If the hashes are added to the serialisation of unique_objects_container, the load should speed up.

Hence the issue is to add the hashes back into the serialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant