forked from envoyproxy/envoy
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathconnection_handler_test.cc
1162 lines (1021 loc) · 56.5 KB
/
connection_handler_test.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
#include "envoy/config/core/v3/base.pb.h"
#include "envoy/config/listener/v3/udp_listener_config.pb.h"
#include "envoy/network/exception.h"
#include "envoy/network/filter.h"
#include "envoy/server/active_udp_listener_config.h"
#include "envoy/stats/scope.h"
#include "common/common/utility.h"
#include "common/config/utility.h"
#include "common/network/address_impl.h"
#include "common/network/connection_balancer_impl.h"
#include "common/network/io_socket_handle_impl.h"
#include "common/network/raw_buffer_socket.h"
#include "common/network/udp_default_writer_config.h"
#include "common/network/udp_listener_impl.h"
#include "common/network/utility.h"
#include "server/connection_handler_impl.h"
#include "test/mocks/access_log/mocks.h"
#include "test/mocks/api/mocks.h"
#include "test/mocks/common.h"
#include "test/mocks/network/mocks.h"
#include "test/test_common/network_utility.h"
#include "test/test_common/threadsafe_singleton_injector.h"
#include "gmock/gmock.h"
#include "gtest/gtest.h"
using testing::_;
using testing::HasSubstr;
using testing::InSequence;
using testing::Invoke;
using testing::NiceMock;
using testing::Return;
using testing::ReturnRef;
using testing::SaveArg;
namespace Envoy {
namespace Server {
namespace {
class ConnectionHandlerTest : public testing::Test, protected Logger::Loggable<Logger::Id::main> {
public:
ConnectionHandlerTest()
: socket_factory_(std::make_shared<Network::MockListenSocketFactory>()),
handler_(new ConnectionHandlerImpl(dispatcher_, 0)),
filter_chain_(Network::Test::createEmptyFilterChainWithRawBufferSockets()),
listener_filter_matcher_(std::make_shared<NiceMock<Network::MockListenerFilterMatcher>>()),
access_log_(std::make_shared<AccessLog::MockInstance>()) {
ON_CALL(*listener_filter_matcher_, matches(_)).WillByDefault(Return(false));
}
class TestListener : public Network::ListenerConfig {
public:
TestListener(
ConnectionHandlerTest& parent, uint64_t tag, bool bind_to_port,
bool hand_off_restored_destination_connections, const std::string& name,
Network::Socket::Type socket_type, std::chrono::milliseconds listener_filters_timeout,
bool continue_on_listener_filters_timeout,
Network::ListenSocketFactorySharedPtr socket_factory,
std::shared_ptr<AccessLog::MockInstance> access_log,
std::shared_ptr<NiceMock<Network::MockFilterChainManager>> filter_chain_manager = nullptr,
uint32_t tcp_backlog_size = ENVOY_TCP_BACKLOG_SIZE,
Network::ConnectionBalancerSharedPtr connection_balancer = nullptr)
: parent_(parent), socket_(std::make_shared<NiceMock<Network::MockListenSocket>>()),
socket_factory_(std::move(socket_factory)), tag_(tag), bind_to_port_(bind_to_port),
tcp_backlog_size_(tcp_backlog_size),
hand_off_restored_destination_connections_(hand_off_restored_destination_connections),
name_(name), listener_filters_timeout_(listener_filters_timeout),
continue_on_listener_filters_timeout_(continue_on_listener_filters_timeout),
connection_balancer_(connection_balancer == nullptr
? std::make_shared<Network::NopConnectionBalancerImpl>()
: connection_balancer),
access_logs_({access_log}), inline_filter_chain_manager_(filter_chain_manager),
init_manager_(nullptr) {
envoy::config::listener::v3::UdpListenerConfig dummy;
std::string listener_name("raw_udp_listener");
dummy.set_udp_listener_name(listener_name);
udp_listener_factory_ =
Config::Utility::getAndCheckFactoryByName<ActiveUdpListenerConfigFactory>(listener_name)
.createActiveUdpListenerFactory(dummy, /*concurrency=*/1);
udp_writer_factory_ = std::make_unique<Network::UdpDefaultWriterFactory>();
ON_CALL(*socket_, socketType()).WillByDefault(Return(socket_type));
}
// Network::ListenerConfig
Network::FilterChainManager& filterChainManager() override {
return inline_filter_chain_manager_ == nullptr ? parent_.manager_
: *inline_filter_chain_manager_;
}
Network::FilterChainFactory& filterChainFactory() override { return parent_.factory_; }
Network::ListenSocketFactory& listenSocketFactory() override { return *socket_factory_; }
bool bindToPort() override { return bind_to_port_; }
bool handOffRestoredDestinationConnections() const override {
return hand_off_restored_destination_connections_;
}
uint32_t perConnectionBufferLimitBytes() const override { return 0; }
std::chrono::milliseconds listenerFiltersTimeout() const override {
return listener_filters_timeout_;
}
bool continueOnListenerFiltersTimeout() const override {
return continue_on_listener_filters_timeout_;
}
Stats::Scope& listenerScope() override { return parent_.stats_store_; }
uint64_t listenerTag() const override { return tag_; }
const std::string& name() const override { return name_; }
Network::ActiveUdpListenerFactory* udpListenerFactory() override {
return udp_listener_factory_.get();
}
Network::UdpPacketWriterFactoryOptRef udpPacketWriterFactory() override {
return Network::UdpPacketWriterFactoryOptRef(std::ref(*udp_writer_factory_));
}
Network::UdpListenerWorkerRouterOptRef udpListenerWorkerRouter() override {
return *udp_listener_worker_router_;
}
envoy::config::core::v3::TrafficDirection direction() const override {
return envoy::config::core::v3::UNSPECIFIED;
}
Network::ConnectionBalancer& connectionBalancer() override { return *connection_balancer_; }
const std::vector<AccessLog::InstanceSharedPtr>& accessLogs() const override {
return access_logs_;
}
ResourceLimit& openConnections() override { return open_connections_; }
uint32_t tcpBacklogSize() const override { return tcp_backlog_size_; }
Init::Manager& initManager() override { return *init_manager_; }
void setMaxConnections(const uint32_t num_connections) {
open_connections_.setMax(num_connections);
}
void clearMaxConnections() { open_connections_.resetMax(); }
ConnectionHandlerTest& parent_;
std::shared_ptr<NiceMock<Network::MockListenSocket>> socket_;
Network::ListenSocketFactorySharedPtr socket_factory_;
uint64_t tag_;
bool bind_to_port_;
const uint32_t tcp_backlog_size_;
const bool hand_off_restored_destination_connections_;
const std::string name_;
const std::chrono::milliseconds listener_filters_timeout_;
const bool continue_on_listener_filters_timeout_;
std::unique_ptr<Network::ActiveUdpListenerFactory> udp_listener_factory_;
std::unique_ptr<Network::UdpPacketWriterFactory> udp_writer_factory_;
Network::UdpListenerWorkerRouterPtr udp_listener_worker_router_;
Network::ConnectionBalancerSharedPtr connection_balancer_;
BasicResourceLimitImpl open_connections_;
const std::vector<AccessLog::InstanceSharedPtr> access_logs_;
std::shared_ptr<NiceMock<Network::MockFilterChainManager>> inline_filter_chain_manager_;
std::unique_ptr<Init::Manager> init_manager_;
};
using TestListenerPtr = std::unique_ptr<TestListener>;
class MockUpstreamUdpFilter : public Network::UdpListenerReadFilter {
public:
MockUpstreamUdpFilter(ConnectionHandlerTest& parent, Network::UdpReadFilterCallbacks& callbacks)
: UdpListenerReadFilter(callbacks), parent_(parent) {}
~MockUpstreamUdpFilter() override {
parent_.deleted_before_listener_ = !parent_.udp_listener_deleted_;
}
MOCK_METHOD(void, onData, (Network::UdpRecvData&), (override));
MOCK_METHOD(void, onReceiveError, (Api::IoError::IoErrorCode), (override));
private:
ConnectionHandlerTest& parent_;
};
class MockUpstreamUdpListener : public Network::UdpListener {
public:
explicit MockUpstreamUdpListener(ConnectionHandlerTest& parent) : parent_(parent) {
ON_CALL(*this, dispatcher()).WillByDefault(ReturnRef(dispatcher_));
}
~MockUpstreamUdpListener() override { parent_.udp_listener_deleted_ = true; }
MOCK_METHOD(void, enable, (), (override));
MOCK_METHOD(void, disable, (), (override));
MOCK_METHOD(Event::Dispatcher&, dispatcher, (), (override));
MOCK_METHOD(Network::Address::InstanceConstSharedPtr&, localAddress, (), (const, override));
MOCK_METHOD(Api::IoCallUint64Result, send, (const Network::UdpSendData&), (override));
MOCK_METHOD(Api::IoCallUint64Result, flush, (), (override));
MOCK_METHOD(void, activateRead, (), (override));
private:
ConnectionHandlerTest& parent_;
Event::MockDispatcher dispatcher_;
};
TestListener* addListener(
uint64_t tag, bool bind_to_port, bool hand_off_restored_destination_connections,
const std::string& name, Network::Listener* listener,
Network::TcpListenerCallbacks** listener_callbacks = nullptr,
std::shared_ptr<Network::MockConnectionBalancer> connection_balancer = nullptr,
Network::BalancedConnectionHandler** balanced_connection_handler = nullptr,
Network::Socket::Type socket_type = Network::Socket::Type::Stream,
std::chrono::milliseconds listener_filters_timeout = std::chrono::milliseconds(15000),
bool continue_on_listener_filters_timeout = false,
std::shared_ptr<NiceMock<Network::MockFilterChainManager>> overridden_filter_chain_manager =
nullptr,
uint32_t tcp_backlog_size = ENVOY_TCP_BACKLOG_SIZE) {
listeners_.emplace_back(std::make_unique<TestListener>(
*this, tag, bind_to_port, hand_off_restored_destination_connections, name, socket_type,
listener_filters_timeout, continue_on_listener_filters_timeout, socket_factory_,
access_log_, overridden_filter_chain_manager, tcp_backlog_size, connection_balancer));
EXPECT_CALL(*socket_factory_, socketType()).WillOnce(Return(socket_type));
if (listener == nullptr) {
// Expecting listener config in place update.
// If so, dispatcher would not create new network listener.
return listeners_.back().get();
}
EXPECT_CALL(*socket_factory_, getListenSocket()).WillOnce(Return(listeners_.back()->socket_));
if (socket_type == Network::Socket::Type::Stream) {
EXPECT_CALL(dispatcher_, createListener_(_, _, _, _))
.WillOnce(Invoke([listener, listener_callbacks](Network::SocketSharedPtr&&,
Network::TcpListenerCallbacks& cb, bool,
uint32_t) -> Network::Listener* {
if (listener_callbacks != nullptr) {
*listener_callbacks = &cb;
}
return listener;
}));
} else {
EXPECT_CALL(dispatcher_, createUdpListener_(_, _))
.WillOnce(Invoke([listener](Network::SocketSharedPtr&&,
Network::UdpListenerCallbacks&) -> Network::UdpListener* {
return dynamic_cast<Network::UdpListener*>(listener);
}));
listeners_.back()->udp_listener_worker_router_ =
std::make_unique<Network::UdpListenerWorkerRouterImpl>(1);
}
if (balanced_connection_handler != nullptr) {
EXPECT_CALL(*connection_balancer, registerHandler(_))
.WillOnce(SaveArgAddress(balanced_connection_handler));
}
return listeners_.back().get();
}
Stats::TestUtil::TestStore stats_store_;
std::shared_ptr<Network::MockListenSocketFactory> socket_factory_;
Network::Address::InstanceConstSharedPtr local_address_{
new Network::Address::Ipv4Instance("127.0.0.1", 10001)};
NiceMock<Event::MockDispatcher> dispatcher_{"test"};
std::list<TestListenerPtr> listeners_;
Network::ConnectionHandlerPtr handler_;
NiceMock<Network::MockFilterChainManager> manager_;
NiceMock<Network::MockFilterChainFactory> factory_;
const Network::FilterChainSharedPtr filter_chain_;
NiceMock<Api::MockOsSysCalls> os_sys_calls_;
TestThreadsafeSingletonInjector<Api::OsSysCallsImpl> os_calls_{&os_sys_calls_};
std::shared_ptr<NiceMock<Network::MockListenerFilterMatcher>> listener_filter_matcher_;
bool udp_listener_deleted_ = false;
bool deleted_before_listener_ = false;
std::shared_ptr<AccessLog::MockInstance> access_log_;
};
// Verify that if a listener is removed while a rebalanced connection is in flight, we correctly
// destroy the connection.
TEST_F(ConnectionHandlerTest, RemoveListenerDuringRebalance) {
InSequence s;
// For reasons I did not investigate, the death test below requires this, likely due to forking.
// So we just leak the FDs for this test.
ON_CALL(os_sys_calls_, close(_)).WillByDefault(Return(Api::SysCallIntResult{0, 0}));
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
auto connection_balancer = std::make_shared<Network::MockConnectionBalancer>();
Network::BalancedConnectionHandler* current_handler;
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks,
connection_balancer, ¤t_handler);
EXPECT_CALL(*socket_factory_, localAddress()).WillOnce(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
// Fake a balancer posting a connection to us.
Event::PostCb post_cb;
EXPECT_CALL(dispatcher_, post(_)).WillOnce(SaveArg<0>(&post_cb));
Network::MockConnectionSocket* connection = new NiceMock<Network::MockConnectionSocket>();
current_handler->incNumConnections();
#ifndef NDEBUG
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
#endif
current_handler->post(Network::ConnectionSocketPtr{connection});
EXPECT_CALL(*connection_balancer, unregisterHandler(_));
// This also tests the assert in ConnectionHandlerImpl::ActiveTcpListener::~ActiveTcpListener.
// See the long comment at the end of that function.
#ifndef NDEBUG
// On debug builds this should crash.
EXPECT_DEATH(handler_->removeListeners(1), ".*num_listener_connections_ == 0.*");
// The original test continues without the previous line being run. To avoid the same assert
// firing during teardown, run the posted callback now.
post_cb();
ASSERT(post_cb != nullptr);
EXPECT_CALL(*listener, onDestroy());
#else
// On release builds this should be fine.
EXPECT_CALL(*listener, onDestroy());
handler_->removeListeners(1);
post_cb();
#endif
}
TEST_F(ConnectionHandlerTest, ListenerConnectionLimitEnforced) {
Network::TcpListenerCallbacks* listener_callbacks1;
auto listener1 = new NiceMock<Network::MockListener>();
TestListener* test_listener1 =
addListener(1, false, false, "test_listener1", listener1, &listener_callbacks1);
Network::Address::InstanceConstSharedPtr normal_address(
new Network::Address::Ipv4Instance("127.0.0.1", 10001));
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(normal_address));
// Only allow a single connection on this listener.
test_listener1->setMaxConnections(1);
handler_->addListener(absl::nullopt, *test_listener1);
auto listener2 = new NiceMock<Network::MockListener>();
Network::TcpListenerCallbacks* listener_callbacks2;
TestListener* test_listener2 =
addListener(2, false, false, "test_listener2", listener2, &listener_callbacks2);
Network::Address::InstanceConstSharedPtr alt_address(
new Network::Address::Ipv4Instance("127.0.0.2", 20002));
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(alt_address));
// Do not allow any connections on this listener.
test_listener2->setMaxConnections(0);
handler_->addListener(absl::nullopt, *test_listener2);
EXPECT_CALL(manager_, findFilterChain(_)).WillRepeatedly(Return(filter_chain_.get()));
EXPECT_CALL(factory_, createNetworkFilterChain(_, _)).WillRepeatedly(Return(true));
Network::MockListenerFilter* test_filter = new Network::MockListenerFilter();
EXPECT_CALL(*test_filter, destroy_());
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
manager.addAcceptFilter(listener_filter_matcher_, Network::ListenerFilterPtr{test_filter});
return true;
}));
EXPECT_CALL(*test_filter, onAccept(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterCallbacks&) -> Network::FilterStatus {
return Network::FilterStatus::Continue;
}));
// For listener 2, verify its connection limit is independent of listener 1.
// We expect that listener 2 accepts the connection, so there will be a call to
// createServerConnection and active cx should increase, while cx overflow remains the same.
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
listener_callbacks2->onAccept(
Network::ConnectionSocketPtr{new NiceMock<Network::MockConnectionSocket>()});
EXPECT_EQ(0, handler_->numConnections());
EXPECT_EQ(0, TestUtility::findCounter(stats_store_, "downstream_cx_total")->value());
EXPECT_EQ(0, TestUtility::findGauge(stats_store_, "downstream_cx_active")->value());
EXPECT_EQ(1, TestUtility::findCounter(stats_store_, "downstream_cx_overflow")->value());
// For listener 1, verify connections are limited after one goes active.
// First connection attempt should result in an active connection being created.
auto conn1 = new NiceMock<Network::MockConnection>();
EXPECT_CALL(dispatcher_, createServerConnection_()).WillOnce(Return(conn1));
listener_callbacks1->onAccept(
Network::ConnectionSocketPtr{new NiceMock<Network::MockConnectionSocket>()});
EXPECT_EQ(1, handler_->numConnections());
// Note that these stats are not the per-worker stats, but the per-listener stats.
EXPECT_EQ(1, TestUtility::findCounter(stats_store_, "downstream_cx_total")->value());
EXPECT_EQ(1, TestUtility::findGauge(stats_store_, "downstream_cx_active")->value());
EXPECT_EQ(1, TestUtility::findCounter(stats_store_, "downstream_cx_overflow")->value());
// Don't expect server connection to be created, should be instantly closed and increment
// overflow stat.
listener_callbacks1->onAccept(
Network::ConnectionSocketPtr{new NiceMock<Network::MockConnectionSocket>()});
EXPECT_EQ(1, handler_->numConnections());
EXPECT_EQ(1, TestUtility::findCounter(stats_store_, "downstream_cx_total")->value());
EXPECT_EQ(1, TestUtility::findGauge(stats_store_, "downstream_cx_active")->value());
EXPECT_EQ(2, TestUtility::findCounter(stats_store_, "downstream_cx_overflow")->value());
// Check behavior again for good measure.
listener_callbacks1->onAccept(
Network::ConnectionSocketPtr{new NiceMock<Network::MockConnectionSocket>()});
EXPECT_EQ(1, handler_->numConnections());
EXPECT_EQ(1, TestUtility::findCounter(stats_store_, "downstream_cx_total")->value());
EXPECT_EQ(1, TestUtility::findGauge(stats_store_, "downstream_cx_active")->value());
EXPECT_EQ(3, TestUtility::findCounter(stats_store_, "downstream_cx_overflow")->value());
EXPECT_CALL(*listener1, onDestroy());
EXPECT_CALL(*listener2, onDestroy());
}
TEST_F(ConnectionHandlerTest, RemoveListener) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*socket_factory_, localAddress()).WillOnce(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
Network::MockConnectionSocket* connection = new NiceMock<Network::MockConnectionSocket>();
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
listener_callbacks->onAccept(Network::ConnectionSocketPtr{connection});
EXPECT_EQ(0UL, handler_->numConnections());
// Test stop/remove of not existent listener.
handler_->stopListeners(0);
handler_->removeListeners(0);
EXPECT_CALL(*listener, onDestroy());
handler_->stopListeners(1);
EXPECT_CALL(dispatcher_, clearDeferredDeleteList());
handler_->removeListeners(1);
EXPECT_EQ(0UL, handler_->numConnections());
// Test stop/remove of not existent listener.
handler_->stopListeners(0);
handler_->removeListeners(0);
}
TEST_F(ConnectionHandlerTest, DisableListener) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, false, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*socket_factory_, localAddress()).WillOnce(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
EXPECT_CALL(*listener, disable());
EXPECT_CALL(*listener, onDestroy());
handler_->disableListeners();
}
TEST_F(ConnectionHandlerTest, AddDisabledListener) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, false, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*listener, disable());
EXPECT_CALL(*socket_factory_, localAddress()).WillOnce(ReturnRef(local_address_));
EXPECT_CALL(*listener, onDestroy());
handler_->disableListeners();
handler_->addListener(absl::nullopt, *test_listener);
}
TEST_F(ConnectionHandlerTest, DestroyCloseConnections) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*socket_factory_, localAddress()).WillOnce(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
Network::MockConnectionSocket* connection = new NiceMock<Network::MockConnectionSocket>();
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
listener_callbacks->onAccept(Network::ConnectionSocketPtr{connection});
EXPECT_EQ(0UL, handler_->numConnections());
EXPECT_CALL(dispatcher_, clearDeferredDeleteList());
EXPECT_CALL(*listener, onDestroy());
handler_.reset();
}
TEST_F(ConnectionHandlerTest, CloseDuringFilterChainCreate) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*socket_factory_, localAddress()).WillOnce(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
EXPECT_CALL(manager_, findFilterChain(_)).WillOnce(Return(filter_chain_.get()));
Network::MockConnection* connection = new NiceMock<Network::MockConnection>();
EXPECT_CALL(dispatcher_, createServerConnection_()).WillOnce(Return(connection));
EXPECT_CALL(factory_, createNetworkFilterChain(_, _)).WillOnce(Return(true));
EXPECT_CALL(*connection, state()).WillOnce(Return(Network::Connection::State::Closed));
EXPECT_CALL(*connection, addConnectionCallbacks(_)).Times(0);
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
listener_callbacks->onAccept(Network::ConnectionSocketPtr{accepted_socket});
EXPECT_EQ(0UL, handler_->numConnections());
EXPECT_CALL(*listener, onDestroy());
}
TEST_F(ConnectionHandlerTest, CloseConnectionOnEmptyFilterChain) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*socket_factory_, localAddress()).WillOnce(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
EXPECT_CALL(manager_, findFilterChain(_)).WillOnce(Return(filter_chain_.get()));
Network::MockConnection* connection = new NiceMock<Network::MockConnection>();
EXPECT_CALL(dispatcher_, createServerConnection_()).WillOnce(Return(connection));
EXPECT_CALL(factory_, createNetworkFilterChain(_, _)).WillOnce(Return(false));
EXPECT_CALL(*connection, close(Network::ConnectionCloseType::NoFlush));
EXPECT_CALL(*connection, addConnectionCallbacks(_)).Times(0);
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
listener_callbacks->onAccept(Network::ConnectionSocketPtr{accepted_socket});
EXPECT_EQ(0UL, handler_->numConnections());
EXPECT_CALL(*listener, onDestroy());
}
TEST_F(ConnectionHandlerTest, NormalRedirect) {
Network::TcpListenerCallbacks* listener_callbacks1;
auto listener1 = new NiceMock<Network::MockListener>();
TestListener* test_listener1 =
addListener(1, true, true, "test_listener1", listener1, &listener_callbacks1);
Network::Address::InstanceConstSharedPtr normal_address(
new Network::Address::Ipv4Instance("127.0.0.1", 10001));
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(normal_address));
handler_->addListener(absl::nullopt, *test_listener1);
Network::TcpListenerCallbacks* listener_callbacks2;
auto listener2 = new NiceMock<Network::MockListener>();
TestListener* test_listener2 =
addListener(1, false, false, "test_listener2", listener2, &listener_callbacks2);
Network::Address::InstanceConstSharedPtr alt_address(
new Network::Address::Ipv4Instance("127.0.0.2", 20002));
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(alt_address));
handler_->addListener(absl::nullopt, *test_listener2);
auto* test_filter = new NiceMock<Network::MockListenerFilter>();
EXPECT_CALL(*test_filter, destroy_());
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
bool redirected = false;
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
// Insert the Mock filter.
if (!redirected) {
manager.addAcceptFilter(nullptr, Network::ListenerFilterPtr{test_filter});
redirected = true;
}
return true;
}));
EXPECT_CALL(*test_filter, onAccept(_))
.WillOnce(Invoke([&](Network::ListenerFilterCallbacks& cb) -> Network::FilterStatus {
cb.socket().restoreLocalAddress(alt_address);
return Network::FilterStatus::Continue;
}));
EXPECT_CALL(*accepted_socket, restoreLocalAddress(alt_address));
EXPECT_CALL(*accepted_socket, localAddressRestored()).WillOnce(Return(true));
EXPECT_CALL(*accepted_socket, localAddress()).WillRepeatedly(ReturnRef(alt_address));
EXPECT_CALL(manager_, findFilterChain(_)).WillOnce(Return(filter_chain_.get()));
Network::MockConnection* connection = new NiceMock<Network::MockConnection>();
EXPECT_CALL(dispatcher_, createServerConnection_()).WillOnce(Return(connection));
EXPECT_CALL(factory_, createNetworkFilterChain(_, _)).WillOnce(Return(true));
listener_callbacks1->onAccept(Network::ConnectionSocketPtr{accepted_socket});
// Verify per-listener connection stats.
EXPECT_EQ(1UL, handler_->numConnections());
EXPECT_EQ(1UL, TestUtility::findCounter(stats_store_, "downstream_cx_total")->value());
EXPECT_EQ(1UL, TestUtility::findGauge(stats_store_, "downstream_cx_active")->value());
EXPECT_EQ(1UL, TestUtility::findCounter(stats_store_, "test.downstream_cx_total")->value());
EXPECT_EQ(1UL, TestUtility::findGauge(stats_store_, "test.downstream_cx_active")->value());
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
connection->close(Network::ConnectionCloseType::NoFlush);
dispatcher_.clearDeferredDeleteList();
EXPECT_EQ(0UL, TestUtility::findGauge(stats_store_, "downstream_cx_active")->value());
EXPECT_EQ(0UL, TestUtility::findGauge(stats_store_, "test.downstream_cx_active")->value());
EXPECT_CALL(*listener2, onDestroy());
EXPECT_CALL(*listener1, onDestroy());
}
TEST_F(ConnectionHandlerTest, FallbackToWildcardListener) {
Network::TcpListenerCallbacks* listener_callbacks1;
auto listener1 = new NiceMock<Network::MockListener>();
TestListener* test_listener1 =
addListener(1, true, true, "test_listener1", listener1, &listener_callbacks1);
Network::Address::InstanceConstSharedPtr normal_address(
new Network::Address::Ipv4Instance("127.0.0.1", 10001));
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(normal_address));
handler_->addListener(absl::nullopt, *test_listener1);
Network::TcpListenerCallbacks* listener_callbacks2;
auto listener2 = new NiceMock<Network::MockListener>();
TestListener* test_listener2 =
addListener(1, false, false, "test_listener2", listener2, &listener_callbacks2);
Network::Address::InstanceConstSharedPtr any_address = Network::Utility::getIpv4AnyAddress();
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(any_address));
handler_->addListener(absl::nullopt, *test_listener2);
Network::MockListenerFilter* test_filter = new Network::MockListenerFilter();
EXPECT_CALL(*test_filter, destroy_());
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
bool redirected = false;
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
// Insert the Mock filter.
if (!redirected) {
manager.addAcceptFilter(listener_filter_matcher_,
Network::ListenerFilterPtr{test_filter});
redirected = true;
}
return true;
}));
// Zero port to match the port of AnyAddress
Network::Address::InstanceConstSharedPtr alt_address(
new Network::Address::Ipv4Instance("127.0.0.2", 0, nullptr));
EXPECT_CALL(*test_filter, onAccept(_))
.WillOnce(Invoke([&](Network::ListenerFilterCallbacks& cb) -> Network::FilterStatus {
cb.socket().restoreLocalAddress(alt_address);
return Network::FilterStatus::Continue;
}));
EXPECT_CALL(*accepted_socket, restoreLocalAddress(alt_address));
EXPECT_CALL(*accepted_socket, localAddressRestored()).WillOnce(Return(true));
EXPECT_CALL(*accepted_socket, localAddress()).WillRepeatedly(ReturnRef(alt_address));
EXPECT_CALL(manager_, findFilterChain(_)).WillOnce(Return(filter_chain_.get()));
Network::MockConnection* connection = new NiceMock<Network::MockConnection>();
EXPECT_CALL(dispatcher_, createServerConnection_()).WillOnce(Return(connection));
EXPECT_CALL(factory_, createNetworkFilterChain(_, _)).WillOnce(Return(true));
listener_callbacks1->onAccept(Network::ConnectionSocketPtr{accepted_socket});
EXPECT_EQ(1UL, handler_->numConnections());
EXPECT_CALL(*listener2, onDestroy());
EXPECT_CALL(*listener1, onDestroy());
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
}
TEST_F(ConnectionHandlerTest, WildcardListenerWithOriginalDst) {
Network::TcpListenerCallbacks* listener_callbacks1;
auto listener1 = new NiceMock<Network::MockListener>();
TestListener* test_listener1 =
addListener(1, true, true, "test_listener1", listener1, &listener_callbacks1);
Network::Address::InstanceConstSharedPtr normal_address(
new Network::Address::Ipv4Instance("127.0.0.1", 80));
// Original dst address nor port number match that of the listener's address.
Network::Address::InstanceConstSharedPtr original_dst_address(
new Network::Address::Ipv4Instance("127.0.0.2", 8080));
Network::Address::InstanceConstSharedPtr any_address = Network::Utility::getAddressWithPort(
*Network::Utility::getIpv4AnyAddress(), normal_address->ip()->port());
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(any_address));
handler_->addListener(absl::nullopt, *test_listener1);
Network::MockListenerFilter* test_filter = new Network::MockListenerFilter();
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
// Insert the Mock filter.
manager.addAcceptFilter(listener_filter_matcher_, Network::ListenerFilterPtr{test_filter});
return true;
}));
EXPECT_CALL(*test_filter, onAccept(_))
.WillOnce(Invoke([&](Network::ListenerFilterCallbacks& cb) -> Network::FilterStatus {
cb.socket().restoreLocalAddress(original_dst_address);
return Network::FilterStatus::Continue;
}));
EXPECT_CALL(*test_filter, destroy_());
EXPECT_CALL(*accepted_socket, restoreLocalAddress(original_dst_address));
EXPECT_CALL(*accepted_socket, localAddressRestored()).WillOnce(Return(true));
EXPECT_CALL(*accepted_socket, localAddress()).WillRepeatedly(ReturnRef(original_dst_address));
EXPECT_CALL(manager_, findFilterChain(_)).WillOnce(Return(filter_chain_.get()));
Network::MockConnection* connection = new NiceMock<Network::MockConnection>();
EXPECT_CALL(dispatcher_, createServerConnection_()).WillOnce(Return(connection));
EXPECT_CALL(factory_, createNetworkFilterChain(_, _)).WillOnce(Return(true));
listener_callbacks1->onAccept(Network::ConnectionSocketPtr{accepted_socket});
EXPECT_EQ(1UL, handler_->numConnections());
EXPECT_CALL(*listener1, onDestroy());
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
}
TEST_F(ConnectionHandlerTest, WildcardListenerWithNoOriginalDst) {
Network::TcpListenerCallbacks* listener_callbacks1;
auto listener1 = new NiceMock<Network::MockListener>();
TestListener* test_listener1 =
addListener(1, true, true, "test_listener1", listener1, &listener_callbacks1);
Network::Address::InstanceConstSharedPtr normal_address(
new Network::Address::Ipv4Instance("127.0.0.1", 80));
Network::Address::InstanceConstSharedPtr any_address = Network::Utility::getAddressWithPort(
*Network::Utility::getIpv4AnyAddress(), normal_address->ip()->port());
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(any_address));
handler_->addListener(absl::nullopt, *test_listener1);
Network::MockListenerFilter* test_filter = new Network::MockListenerFilter();
EXPECT_CALL(*test_filter, destroy_());
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
// Insert the Mock filter.
manager.addAcceptFilter(listener_filter_matcher_, Network::ListenerFilterPtr{test_filter});
return true;
}));
EXPECT_CALL(*test_filter, onAccept(_)).WillOnce(Return(Network::FilterStatus::Continue));
EXPECT_CALL(*accepted_socket, localAddressRestored()).WillOnce(Return(false));
EXPECT_CALL(*accepted_socket, localAddress()).WillRepeatedly(ReturnRef(normal_address));
EXPECT_CALL(manager_, findFilterChain(_)).WillOnce(Return(filter_chain_.get()));
Network::MockConnection* connection = new NiceMock<Network::MockConnection>();
EXPECT_CALL(dispatcher_, createServerConnection_()).WillOnce(Return(connection));
EXPECT_CALL(factory_, createNetworkFilterChain(_, _)).WillOnce(Return(true));
listener_callbacks1->onAccept(Network::ConnectionSocketPtr{accepted_socket});
EXPECT_EQ(1UL, handler_->numConnections());
EXPECT_CALL(*listener1, onDestroy());
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
}
TEST_F(ConnectionHandlerTest, TransportProtocolDefault) {
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
EXPECT_CALL(*accepted_socket, detectedTransportProtocol())
.WillOnce(Return(absl::string_view("")));
EXPECT_CALL(*accepted_socket, setDetectedTransportProtocol(absl::string_view("raw_buffer")));
EXPECT_CALL(manager_, findFilterChain(_)).WillOnce(Return(nullptr));
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
listener_callbacks->onAccept(Network::ConnectionSocketPtr{accepted_socket});
EXPECT_CALL(*listener, onDestroy());
}
TEST_F(ConnectionHandlerTest, TransportProtocolCustom) {
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
Network::MockListenerFilter* test_filter = new Network::MockListenerFilter();
EXPECT_CALL(*test_filter, destroy_());
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
manager.addAcceptFilter(listener_filter_matcher_, Network::ListenerFilterPtr{test_filter});
return true;
}));
absl::string_view dummy = "dummy";
EXPECT_CALL(*test_filter, onAccept(_))
.WillOnce(Invoke([&](Network::ListenerFilterCallbacks& cb) -> Network::FilterStatus {
cb.socket().setDetectedTransportProtocol(dummy);
return Network::FilterStatus::Continue;
}));
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
EXPECT_CALL(*accepted_socket, setDetectedTransportProtocol(dummy));
EXPECT_CALL(*accepted_socket, detectedTransportProtocol()).WillOnce(Return(dummy));
EXPECT_CALL(manager_, findFilterChain(_)).WillOnce(Return(nullptr));
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
listener_callbacks->onAccept(Network::ConnectionSocketPtr{accepted_socket});
EXPECT_CALL(*listener, onDestroy());
}
// Timeout during listener filter stop iteration.
TEST_F(ConnectionHandlerTest, ListenerFilterTimeout) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
Network::MockListenerFilter* test_filter = new Network::MockListenerFilter();
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
manager.addAcceptFilter(listener_filter_matcher_, Network::ListenerFilterPtr{test_filter});
return true;
}));
EXPECT_CALL(*test_filter, onAccept(_))
.WillOnce(Invoke([&](Network::ListenerFilterCallbacks&) -> Network::FilterStatus {
return Network::FilterStatus::StopIteration;
}));
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
Network::IoSocketHandleImpl io_handle{42};
EXPECT_CALL(*accepted_socket, ioHandle()).WillRepeatedly(ReturnRef(io_handle));
Event::MockTimer* timeout = new Event::MockTimer(&dispatcher_);
EXPECT_CALL(*timeout, enableTimer(std::chrono::milliseconds(15000), _));
listener_callbacks->onAccept(Network::ConnectionSocketPtr{accepted_socket});
Stats::Gauge& downstream_pre_cx_active =
stats_store_.gauge("downstream_pre_cx_active", Stats::Gauge::ImportMode::Accumulate);
EXPECT_EQ(1UL, downstream_pre_cx_active.value());
EXPECT_CALL(*timeout, disableTimer());
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
timeout->invokeCallback();
EXPECT_CALL(*test_filter, destroy_());
dispatcher_.clearDeferredDeleteList();
EXPECT_EQ(0UL, downstream_pre_cx_active.value());
EXPECT_EQ(1UL, stats_store_.counter("downstream_pre_cx_timeout").value());
// Make sure we didn't continue to try create connection.
EXPECT_EQ(0UL, stats_store_.counter("no_filter_chain_match").value());
EXPECT_CALL(*listener, onDestroy());
}
// Continue on timeout during listener filter stop iteration.
TEST_F(ConnectionHandlerTest, ContinueOnListenerFilterTimeout) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks, nullptr, nullptr,
Network::Socket::Type::Stream, std::chrono::milliseconds(15000), true);
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
Network::MockListenerFilter* test_filter = new NiceMock<Network::MockListenerFilter>();
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
manager.addAcceptFilter(listener_filter_matcher_, Network::ListenerFilterPtr{test_filter});
return true;
}));
EXPECT_CALL(*test_filter, onAccept(_))
.WillOnce(Invoke([&](Network::ListenerFilterCallbacks&) -> Network::FilterStatus {
return Network::FilterStatus::StopIteration;
}));
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
Network::IoSocketHandleImpl io_handle{42};
EXPECT_CALL(*accepted_socket, ioHandle()).WillRepeatedly(ReturnRef(io_handle));
Event::MockTimer* timeout = new Event::MockTimer(&dispatcher_);
EXPECT_CALL(*timeout, enableTimer(std::chrono::milliseconds(15000), _));
listener_callbacks->onAccept(Network::ConnectionSocketPtr{accepted_socket});
Stats::Gauge& downstream_pre_cx_active =
stats_store_.gauge("downstream_pre_cx_active", Stats::Gauge::ImportMode::Accumulate);
EXPECT_EQ(1UL, downstream_pre_cx_active.value());
EXPECT_CALL(*test_filter, destroy_());
// Barrier: test_filter must be destructed before findFilterChain
EXPECT_CALL(manager_, findFilterChain(_)).WillOnce(Return(nullptr));
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
EXPECT_CALL(*timeout, disableTimer());
timeout->invokeCallback();
dispatcher_.clearDeferredDeleteList();
EXPECT_EQ(0UL, downstream_pre_cx_active.value());
EXPECT_EQ(1UL, stats_store_.counter("downstream_pre_cx_timeout").value());
// Make sure we continued to try create connection.
EXPECT_EQ(1UL, stats_store_.counter("no_filter_chain_match").value());
EXPECT_CALL(*listener, onDestroy());
}
// Timeout is disabled once the listener filters complete.
TEST_F(ConnectionHandlerTest, ListenerFilterTimeoutResetOnSuccess) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
Network::MockListenerFilter* test_filter = new Network::MockListenerFilter();
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
manager.addAcceptFilter(listener_filter_matcher_, Network::ListenerFilterPtr{test_filter});
return true;
}));
Network::ListenerFilterCallbacks* listener_filter_cb{};
EXPECT_CALL(*test_filter, onAccept(_))
.WillOnce(Invoke([&](Network::ListenerFilterCallbacks& cb) -> Network::FilterStatus {
listener_filter_cb = &cb;
return Network::FilterStatus::StopIteration;
}));
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
Network::IoSocketHandleImpl io_handle{42};
EXPECT_CALL(*accepted_socket, ioHandle()).WillRepeatedly(ReturnRef(io_handle));
Event::MockTimer* timeout = new Event::MockTimer(&dispatcher_);
EXPECT_CALL(*timeout, enableTimer(std::chrono::milliseconds(15000), _));
listener_callbacks->onAccept(Network::ConnectionSocketPtr{accepted_socket});
EXPECT_CALL(*test_filter, destroy_());
EXPECT_CALL(manager_, findFilterChain(_)).WillOnce(Return(nullptr));
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
EXPECT_CALL(*timeout, disableTimer());
listener_filter_cb->continueFilterChain(true);
EXPECT_CALL(*listener, onDestroy());
}
// Ensure there is no timeout when the timeout is disabled with 0s.
TEST_F(ConnectionHandlerTest, ListenerFilterDisabledTimeout) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks, nullptr, nullptr,
Network::Socket::Type::Stream, std::chrono::milliseconds());
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
Network::MockListenerFilter* test_filter = new Network::MockListenerFilter();
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
manager.addAcceptFilter(listener_filter_matcher_, Network::ListenerFilterPtr{test_filter});
return true;
}));
EXPECT_CALL(*test_filter, onAccept(_))
.WillOnce(Invoke([&](Network::ListenerFilterCallbacks&) -> Network::FilterStatus {
return Network::FilterStatus::StopIteration;
}));
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
EXPECT_CALL(dispatcher_, createTimer_(_)).Times(0);
EXPECT_CALL(*test_filter, destroy_());
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
listener_callbacks->onAccept(Network::ConnectionSocketPtr{accepted_socket});
EXPECT_CALL(*listener, onDestroy());
}
// Listener Filter could close socket in the context of listener callback.
TEST_F(ConnectionHandlerTest, ListenerFilterReportError) {
InSequence s;
Network::TcpListenerCallbacks* listener_callbacks;
auto listener = new NiceMock<Network::MockListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, &listener_callbacks);
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(local_address_));
handler_->addListener(absl::nullopt, *test_listener);
Network::MockListenerFilter* first_filter = new Network::MockListenerFilter();
Network::MockListenerFilter* last_filter = new Network::MockListenerFilter();
EXPECT_CALL(factory_, createListenerFilterChain(_))
.WillRepeatedly(Invoke([&](Network::ListenerFilterManager& manager) -> bool {
manager.addAcceptFilter(listener_filter_matcher_, Network::ListenerFilterPtr{first_filter});
manager.addAcceptFilter(listener_filter_matcher_, Network::ListenerFilterPtr{last_filter});
return true;
}));
// The first filter close the socket
EXPECT_CALL(*first_filter, onAccept(_))
.WillOnce(Invoke([&](Network::ListenerFilterCallbacks& cb) -> Network::FilterStatus {
cb.socket().close();
return Network::FilterStatus::StopIteration;
}));
EXPECT_CALL(*access_log_, log(_, _, _, _)).Times(1);
// The last filter won't be invoked
EXPECT_CALL(*last_filter, onAccept(_)).Times(0);
EXPECT_CALL(*first_filter, destroy_());
EXPECT_CALL(*last_filter, destroy_());
Network::MockConnectionSocket* accepted_socket = new NiceMock<Network::MockConnectionSocket>();
listener_callbacks->onAccept(Network::ConnectionSocketPtr{accepted_socket});
dispatcher_.clearDeferredDeleteList();
// Make sure the error leads to no listener timer created.
EXPECT_CALL(dispatcher_, createTimer_(_)).Times(0);
// Make sure we never try to match the filer chain since listener filter doesn't complete.
EXPECT_CALL(manager_, findFilterChain(_)).Times(0);
EXPECT_CALL(*listener, onDestroy());
}
// Ensure an exception is thrown if there are no filters registered for a UDP listener
TEST_F(ConnectionHandlerTest, UdpListenerNoFilterThrowsException) {
InSequence s;
auto listener = new NiceMock<Network::MockUdpListener>();
TestListener* test_listener =
addListener(1, true, false, "test_listener", listener, nullptr, nullptr, nullptr,
Network::Socket::Type::Datagram, std::chrono::milliseconds());
EXPECT_CALL(factory_, createUdpListenerFilterChain(_, _))
.WillOnce(Invoke([&](Network::UdpListenerFilterManager&,
Network::UdpReadFilterCallbacks&) -> bool { return true; }));
EXPECT_CALL(*socket_factory_, localAddress()).WillRepeatedly(ReturnRef(local_address_));
EXPECT_CALL(*listener, onDestroy());
try {
handler_->addListener(absl::nullopt, *test_listener);
FAIL();
} catch (const Network::CreateListenerException& e) {
EXPECT_THAT(
e.what(),
HasSubstr("Cannot create listener as no read filter registered for the udp listener"));
}
}
TEST_F(ConnectionHandlerTest, TcpListenerInplaceUpdate) {
InSequence s;
uint64_t old_listener_tag = 1;
uint64_t new_listener_tag = 2;