Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint version mismatch #4090

Open
kortelyov opened this issue Oct 7, 2024 · 4 comments
Open

golangci-lint version mismatch #4090

kortelyov opened this issue Oct 7, 2024 · 4 comments
Labels
bug Something isn't working O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity

Comments

@kortelyov
Copy link

kortelyov commented Oct 7, 2024

Describe the bug
According to documentation, magalinter v8 should work with golangci-lint v.1.60.1.
But now it's work with 1.59.1 (screenshot below)
https://megalinter.io/latest/descriptors/go_golangci_lint/

Expected behavior
Using golangci-lint version 1.60.1

Screenshots
изображение

@kortelyov kortelyov added the bug Something isn't working label Oct 7, 2024
@nvuillam
Copy link
Member

nvuillam commented Oct 7, 2024

I don't have an explanation :/
Maybe a bug in their --version command... which would be strange because the version written in doc is extracted the same way than in your log :/

Beta version contains 1.61.0 https://megalinter.io/beta/descriptors/go_golangci_lint/ if you can't wait for the next minor release (which should happen as soon as we solve some docker issues with internal CI )

@vihangm
Copy link

vihangm commented Oct 7, 2024

I reported this here
The golangci-lint versions are different based on which flavor of the linter you have.

I'm guessing that either there was a release between when the flavors were built or that some docker build caching grabbed the older version for some of the flavors.

@nvuillam
Copy link
Member

nvuillam commented Oct 7, 2024

When we release MegaLinter, we rebuild from beta version, so the chances of that happening are thin :/
I implemented a workaround for trivy issues, so if i succeed to solve the docker limits, i should succeed to release 8.1.0 this week-end, so the problem should disappear ^^

Copy link
Contributor

github-actions bot commented Nov 7, 2024

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity
Projects
None yet
Development

No branches or pull requests

3 participants