Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHD: build crucible-downstairs automatically if Crucible dep is patched #779

Open
hawkw opened this issue Oct 3, 2024 · 0 comments
Open
Assignees
Labels
testing Related to testing and/or the PHD test framework.

Comments

@hawkw
Copy link
Member

hawkw commented Oct 3, 2024

Currently (as of #778) we force users who have patched the Crucible dep to bring their own downstairs binary in order to build tests. It would be cool if we could detect patched deps and just go build it.

Off-the-wall idea here, but: is it possible to get cargo xtask phd to notice that the Crucible path has been patched and to build a downstairs binary from that path? We could then try to pipe it into a (separate) environment var and have --crucible-downstairs-commit auto try to pick that up: the git rev isn't valid, but I have a proposed path to a Crucible downstairs on the local machine, so let me try that instead.

Originally posted by @gjcolombo in #778 (review)

I wonder if there's some way to (ab)use cargo binary dependencies to accomplish this nicely...

@hawkw hawkw added the testing Related to testing and/or the PHD test framework. label Oct 3, 2024
@hawkw hawkw self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to testing and/or the PHD test framework.
Projects
None yet
Development

No branches or pull requests

1 participant