Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgp: ipv4 unicast NRLI sanity checking #210

Closed
taspelund opened this issue Apr 11, 2024 · 2 comments · Fixed by #199
Closed

bgp: ipv4 unicast NRLI sanity checking #210

taspelund opened this issue Apr 11, 2024 · 2 comments · Fixed by #199
Assignees
@rcgoodfellow
Labels
bgp Border Gateway Protocol want
Milestone
8

Comments

@taspelund
Copy link
Contributor

taspelund commented Apr 11, 2024 •
edited by rcgoodfellow
Loading

Add sanity checks for the contents of IPv6 Unicast NLRI, i.e. making sure they only contain valid unicast addresses.

Ranges to drop as invalid:

IPv4:

  • 127.0.0.0/8
  • 224.0.0.0/4
  • 240.0.0.0/4
  • 169.254.0.0/16 (optional, as this range is sometimes used as loopback ranges similar to RFC 1918)
@taspelund taspelund added want bgp Border Gateway Protocol labels Apr 11, 2024
@rcgoodfellow
Copy link
Collaborator

One more check would be to make sure we don't get an NLRI whose next-hop is itself.
e.g.
10.0.0.1/32 via 10.0.0.1

@rcgoodfellow rcgoodfellow added this to the 8 milestone Apr 14, 2024
@rcgoodfellow rcgoodfellow self-assigned this Apr 14, 2024
@rcgoodfellow rcgoodfellow changed the title bgp: Unicast NRLI sanity checking bgp: ipv4 unicast NRLI sanity checking Apr 14, 2024
@rcgoodfellow
Copy link
Collaborator

Moved IPv6 part of this ticket to #211

rcgoodfellow added a commit that referenced this issue Apr 14, 2024
@rcgoodfellow
ipv4 unicast nlri checking
50c52ea 
- addresses #210 for ipv4
@rcgoodfellow rcgoodfellow mentioned this issue Apr 14, 2024
Merged
rcgoodfellow added a commit that referenced this issue Apr 26, 2024
@rcgoodfellow
ipv4 unicast nlri checking
74c3d92 
- addresses #210 for ipv4
rcgoodfellow added a commit that referenced this issue May 2, 2024
@rcgoodfellow
ipv4 unicast nlri checking
d91c783 
- addresses #210 for ipv4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcgoodfellow rcgoodfellow

Labels
bgp Border Gateway Protocol want
Projects
None yet
Milestone
8
Development

Successfully merging a pull request may close this issue.

0xPop oxidecomputer/maghemite
2 participants
@rcgoodfellow @taspelund