Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing wildcard imports kind of stalled out. #1894

Open
cbiffle opened this issue Oct 7, 2024 · 1 comment
Open

Removing wildcard imports kind of stalled out. #1894

cbiffle opened this issue Oct 7, 2024 · 1 comment
Labels
developer-experience Fixing this would have a positive impact on developer experience

Comments

@cbiffle
Copy link
Collaborator

cbiffle commented Oct 7, 2024

After achieving consensus with the team, in #1752 I started removing uses of wildcard imports (that is, use somecrate::*;) in Hubris. I'm using Clippy to try to avoid regressions in the areas where they've been removed.

But there's a lot of Hubris left, and new wildcard imports are occasionally still added (potentially by copy-paste from previous ones).

It would be nice to clean the rest of this up, and it would be nice to spread the work across more people than just me.

@cbiffle cbiffle added the developer-experience Fixing this would have a positive impact on developer experience label Oct 7, 2024
@aapoalas
Copy link
Contributor

I'm interested in doing more of these mechanical cleanups, if that is considered permissible. #1857 removes the rest of userlib::* imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Fixing this would have a positive impact on developer experience
Projects
None yet
Development

No branches or pull requests

2 participants