Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop arbitrary values help text #2447

Open
david-crespo opened this issue Sep 16, 2024 · 0 comments
Open

Workshop arbitrary values help text #2447

david-crespo opened this issue Sep 16, 2024 · 0 comments
Labels
Milestone

Comments

@david-crespo
Copy link
Collaborator

Select an option or enter a custom value

What we have is decent, but I just want to flag that we should keep mulling it over before v11 in case we come up with something better. It might help to explain somewhere (in this help text or elsewhere) that the match works by string, and therefore it can be any string, even one that doesn't match any instances yet. At least, that's what I want to convey — doesn't mean we have to say it exactly like that.

{valueType === 'vpc' || valueType === 'subnet' || valueType === 'instance' ? (
<ComboboxField
isDisabled={isDisabled}
name="value"
{...getFilterValueProps(valueType)}
description="Select an option or enter a custom value"

@david-crespo david-crespo added this to the 11 milestone Sep 16, 2024
@david-crespo david-crespo modified the milestones: 11, 12 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant